Fix Visual Studio on ARM Compilation #1315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes Windows on ARM native Visual Studio compilation. The current #ifdef logic assumes that Visual Studio always targets x86/x64, which is no longer the case. Unfortunately based on: https://learn.microsoft.com/en-us/cpp/preprocessor/predefined-macros?view=msvc-170 there doesn't seem to be a single macro to test Intel vs ARM compilation. With this change, OpenEXR compiles native to ARM on Windows and passes its test suite. Signed-off-by: Jean-Francois Panisset <[email protected]>
Signed-off-by: Jean-Francois Panisset <[email protected]>
meshula
approved these changes
Nov 12, 2022
|
Thanks for figuring that out. |
cary-ilm
pushed a commit
to cary-ilm/openexr
that referenced
this pull request
Mar 3, 2023
* Fix Visual Studio on ARM Compilation. This fixes Windows on ARM native Visual Studio compilation. The current #ifdef logic assumes that Visual Studio always targets x86/x64, which is no longer the case. Unfortunately based on: https://learn.microsoft.com/en-us/cpp/preprocessor/predefined-macros?view=msvc-170 there doesn't seem to be a single macro to test Intel vs ARM compilation. With this change, OpenEXR compiles native to ARM on Windows and passes its test suite. Signed-off-by: Jean-Francois Panisset <[email protected]> * Typo fix Signed-off-by: Jean-Francois Panisset <[email protected]> Signed-off-by: Jean-Francois Panisset <[email protected]>
cary-ilm
pushed a commit
that referenced
this pull request
Mar 5, 2023
* Fix Visual Studio on ARM Compilation. This fixes Windows on ARM native Visual Studio compilation. The current #ifdef logic assumes that Visual Studio always targets x86/x64, which is no longer the case. Unfortunately based on: https://learn.microsoft.com/en-us/cpp/preprocessor/predefined-macros?view=msvc-170 there doesn't seem to be a single macro to test Intel vs ARM compilation. With this change, OpenEXR compiles native to ARM on Windows and passes its test suite. Signed-off-by: Jean-Francois Panisset <[email protected]> * Typo fix Signed-off-by: Jean-Francois Panisset <[email protected]> Signed-off-by: Jean-Francois Panisset <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes Windows on ARM native Visual Studio compilation. The current #ifdef
logic assumes that Visual Studio always targets x86/x64, which is no longer the case.
Unfortunately based on:
https://learn.microsoft.com/en-us/cpp/preprocessor/predefined-macros?view=msvc-170
there doesn't seem to be a single macro to test Intel vs ARM compilation, hence the ugly logic.
With this change, OpenEXR compiles native to ARM on Windows and passes its test suite.