Address OSS Fuzz Issues #1268
Merged
Address OSS Fuzz Issues #1268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add location to extract internal helper functions to reduce code duplication Signed-off-by: Kimball Thurston <[email protected]>
Use new compute_sampled_lines when the y_sampling is odd (sampling % 2 == 1), where the number of lines per chunk will oscillate. Signed-off-by: Kimball Thurston <[email protected]>
Signed-off-by: Kimball Thurston <[email protected]>
Use a minimum size to handle that b44 is always 4x4 blocks Signed-off-by: Kimball Thurston <[email protected]>
use the scratch buffer size instead of decompressed buffer size, allow some extra padding in scratch buffer when appropriate Signed-off-by: Kimball Thurston <[email protected]>
meshula
approved these changes
Jul 10, 2022
| int64_t chunk = (int64_t) leader.scanline_y; | ||
| chunk -= (int64_t) part->data_window.min.y; | ||
| chunk /= part->lines_per_chunk; | ||
| if (chunk < 0 || chunk > INT32_MAX) |
There was a problem hiding this comment.
I assume the INT32_MAX (as opposed to another constant) is consistent with the rest of the implementation of the core?
cary-ilm
pushed a commit
to cary-ilm/openexr
that referenced
this pull request
Mar 3, 2023
* Add utility function header Add location to extract internal helper functions to reduce code duplication Signed-off-by: Kimball Thurston <[email protected]> * Fix issues with odd y_sampling numbers Use new compute_sampled_lines when the y_sampling is odd (sampling % 2 == 1), where the number of lines per chunk will oscillate. Signed-off-by: Kimball Thurston <[email protected]> * Fix integer overflow computing deep chunk index Signed-off-by: Kimball Thurston <[email protected]> * Fix decompression scratch buffer size Use a minimum size to handle that b44 is always 4x4 blocks Signed-off-by: Kimball Thurston <[email protected]> * Use appropriate buffer size when decompressing use the scratch buffer size instead of decompressed buffer size, allow some extra padding in scratch buffer when appropriate Signed-off-by: Kimball Thurston <[email protected]>
cary-ilm
pushed a commit
that referenced
this pull request
Mar 5, 2023
* Add utility function header Add location to extract internal helper functions to reduce code duplication Signed-off-by: Kimball Thurston <[email protected]> * Fix issues with odd y_sampling numbers Use new compute_sampled_lines when the y_sampling is odd (sampling % 2 == 1), where the number of lines per chunk will oscillate. Signed-off-by: Kimball Thurston <[email protected]> * Fix integer overflow computing deep chunk index Signed-off-by: Kimball Thurston <[email protected]> * Fix decompression scratch buffer size Use a minimum size to handle that b44 is always 4x4 blocks Signed-off-by: Kimball Thurston <[email protected]> * Use appropriate buffer size when decompressing use the scratch buffer size instead of decompressed buffer size, allow some extra padding in scratch buffer when appropriate Signed-off-by: Kimball Thurston <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address:
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=47483
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=47503
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=47517
There was a set of issues when the y sampling of a file was odd and not 1 (as in not even, not just bogus), and further memory issues decoding very small files (i.e. width of 1)