Fix gcc 13 build #1262
Closed
Fix gcc 13 build #1262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without the change build fails on this week's gcc-13 as:
[ 7%] Building CXX object src/lib/OpenEXR/CMakeFiles/OpenEXR.dir/ImfDeepTiledInputPart.cpp.o
In file included from openexr/src/lib/OpenEXR/ImfDeepTiledInputPart.cpp:6:
openexr/src/lib/OpenEXR/ImfDeepTiledInputPart.h:297:57: error: 'uint64_t' has not been declared
297 | int& dx, int& dy, int& lx, int& ly, char* data, uint64_t& dataSize)
| ^~~~~~~~
Signed-off-by: Sergei Trofimovich <[email protected]>
Without the change build fails on this week's gcc-13 as:
[ 23%] Building CXX object src/lib/OpenEXR/CMakeFiles/OpenEXR.dir/ImfDeepTiledOutputPart.cpp.o
In file included from openexr/src/lib/OpenEXR/ImfDeepTiledInputFile.cpp:12:
openexr/src/lib/OpenEXR/ImfDeepTiledInputFile.h:341:62: error: 'uint64_t' has not been declared
341 | int& dx, int& dy, int& lx, int& ly, char* pixelData, uint64_t& dataSize)
| ^~~~~~~~
Signed-off-by: Sergei Trofimovich <[email protected]>
Without the change build fails on this week's gcc-13 as:
[ 99%] Building CXX object src/test/OpenEXRTest/CMakeFiles/OpenEXRTest.dir/testInputPart.cpp.o
openexr/src/bin/exrcheck/main.cpp: In function 'bool exrCheck(const char*, bool, bool, bool, bool)':
openexr/src/bin/exrcheck/main.cpp:65:15: error: 'uintptr_t' does not name a type
65 | const uintptr_t kMaxSize = uintptr_t (-1) / 4;
| ^~~~~~~~~
Signed-off-by: Sergei Trofimovich <[email protected]>
|
cary-ilm
added a commit
to cary-ilm/openexr
that referenced
this pull request
Jun 2, 2022
Originally submitted as AcademySoftwareFoundation#1262, thanks. Signed-off-by: Cary Phillips <[email protected]>
|
Thanks for the catch, and apologies for the delay. To save you the hassle of signing the CLA, I submitted #1264. The ASWF policy is to require a signed CLA for all PRs. If you'd prefer to sign, I'm happy to accept this instead. |
|
Please submit your version. I'd prefer not to explore CLA signing for this one-liner. I'll close this PR. Thank you! |
cary-ilm
added a commit
that referenced
this pull request
Jul 31, 2022
Originally submitted as #1262, thanks. Signed-off-by: Cary Phillips <[email protected]>
cary-ilm
added a commit
to cary-ilm/openexr
that referenced
this pull request
Mar 3, 2023
…ndation#1264) Originally submitted as AcademySoftwareFoundation#1262, thanks. Signed-off-by: Cary Phillips <[email protected]>
cary-ilm
added a commit
that referenced
this pull request
Mar 5, 2023
Originally submitted as #1262, thanks. Signed-off-by: Cary Phillips <[email protected]>
mloccy
added a commit
to mloccy/openexr
that referenced
this pull request
Apr 18, 2024
…ndation#1264) Originally submitted as AcademySoftwareFoundation#1262, thanks. Signed-off-by: Cary Phillips <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gcc-13did a bit of implicit header inclusion hygiene. This exposed a few build failures inopenexr. The change restores the build by adding<cstdint>includes.