Fix misc issues due to OSS-fuzz #1173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds a (disabled) error handler print to make th test cases easier to part - Fixes an initialization of buffers to use the better half - mark a couple of functions internal (static) Signed-off-by: Kimball Thurston <[email protected]>
Signed-off-by: Kimball Thurston <[email protected]>
Signed-off-by: Kimball Thurston <[email protected]>
Signed-off-by: Kimball Thurston <[email protected]>
…sampling Signed-off-by: Kimball Thurston <[email protected]>
cary-ilm
reviewed
Oct 5, 2021
cary-ilm
reviewed
Oct 6, 2021
src/lib/OpenEXRUtil/ImfCheckFile.cpp
Outdated
| static void | ||
| core_error_handler_cb (exr_const_context_t f, int code, const char* msg) | ||
| { | ||
| #if 0 |
There was a problem hiding this comment.
well, yes and no. I should add a comment to this at the very least. Peter requested to silence the error prints to make the oss fuzz logs smaller and easier to parse, but then I also want the debug prints to know something has happened. Let me circle back with him and we can decide how to enable it. perhaps an env var instead of if 0 and re-compile.
Signed-off-by: Kimball Thurston <[email protected]>
cary-ilm
pushed a commit
to cary-ilm/openexr
that referenced
this pull request
Oct 14, 2021
* Fix issues with fuzz test driver - Adds a (disabled) error handler print to make th test cases easier to part - Fixes an initialization of buffers to use the better half - mark a couple of functions internal (static) Signed-off-by: Kimball Thurston <[email protected]> * Add chunk for offsets in chunk table to be (somewhat validate) Signed-off-by: Kimball Thurston <[email protected]> * Clarify comment, simplify logic check Signed-off-by: Kimball Thurston <[email protected]> * Add check in mirror decode pipeline for alloc of 0 bytes Signed-off-by: Kimball Thurston <[email protected]> * Adjust logic so we can handle single scanline compression with image sampling Signed-off-by: Kimball Thurston <[email protected]> * switch to controlling prints for checking behind a getenv Signed-off-by: Kimball Thurston <[email protected]>
cary-ilm
pushed a commit
that referenced
this pull request
Oct 24, 2021
* Fix issues with fuzz test driver - Adds a (disabled) error handler print to make th test cases easier to part - Fixes an initialization of buffers to use the better half - mark a couple of functions internal (static) Signed-off-by: Kimball Thurston <[email protected]> * Add chunk for offsets in chunk table to be (somewhat validate) Signed-off-by: Kimball Thurston <[email protected]> * Clarify comment, simplify logic check Signed-off-by: Kimball Thurston <[email protected]> * Add check in mirror decode pipeline for alloc of 0 bytes Signed-off-by: Kimball Thurston <[email protected]> * Adjust logic so we can handle single scanline compression with image sampling Signed-off-by: Kimball Thurston <[email protected]> * switch to controlling prints for checking behind a getenv Signed-off-by: Kimball Thurston <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many errors were masked by the fix to properly interpret the channel list attribute size parameter. This attempts to fix those issues as a first pass