Simplify names, improve error messages, fix imath usage in Core #1086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a consistency pass over the names to refer to all pixel data blocks as chunk, as is outlined in the master OpenEXR file layout documentation around version 2.0. Additionally cleans up up some prints, splits an overloaded error enum into three. Signed-off-by: Kimball Thurston <[email protected]>
lgritz
approved these changes
Jul 11, 2021
meshula
approved these changes
Jul 11, 2021
|
we haven't released yet, which is why I went with the name changes now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a consistency pass over the names to refer to all pixel data
blocks as chunk, as is outlined in the master OpenEXR file layout
documentation around version 2.0.
Additionally cleans up up some prints, splits an overloaded error enum
into three.
Signed-off-by: Kimball Thurston [email protected]