-
Notifications
You must be signed in to change notification settings - Fork 626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements for Bazel build support #1015
Conversation
Signed-off-by: Vertexwahn <[email protected]>
Signed-off-by: Vertexwahn <[email protected]>
Signed-off-by: Vertexwahn <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Matches Cary's latest changes to CMake vis a vis versioning, although I don't see anything around soversion, is that a thing in a Bazel build?
* Pin Imath version to 3.0.1 (instead of Imath 3.0.0 beta) Signed-off-by: Vertexwahn <[email protected]> * Add comments for treating compile warnings as errors Signed-off-by: Vertexwahn <[email protected]> * Improve config headers for Imath Signed-off-by: Vertexwahn <[email protected]>
Currently, the Bazel version of OpenEXR is only linked statically - so there is currently no soversion for the Bazel build. |
* Pin Imath version to 3.0.1 (instead of Imath 3.0.0 beta) Signed-off-by: Vertexwahn <[email protected]> * Add comments for treating compile warnings as errors Signed-off-by: Vertexwahn <[email protected]> * Improve config headers for Imath Signed-off-by: Vertexwahn <[email protected]> Signed-off-by: Cary Phillips <[email protected]>
* Pin Imath version to 3.0.1 (instead of Imath 3.0.0 beta) Signed-off-by: Vertexwahn <[email protected]> * Add comments for treating compile warnings as errors Signed-off-by: Vertexwahn <[email protected]> * Improve config headers for Imath Signed-off-by: Vertexwahn <[email protected]> Signed-off-by: Cary Phillips <[email protected]>
Some improvements for Bazel build experience. Only changes to Bazel build files.