Avoid overflow in calculateNumTiles when size=MAX_INT (#825)

* Avoid overflow in calculateNumTiles when size=MAX_INT Signed-off-by: Cary Phillips <[email protected]> * Compute level size with 64 bits to avoid overflow Signed-off-by: Cary Phillips <[email protected]>
AcademySoftwareFoundation · Aug 30, 2020 · 2a18ed4 · 2a18ed4
1 parent 0963ff1
commit 2a18ed4
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/OpenEXR/IlmImf/ImfTiledMisc.cpp b/OpenEXR/IlmImf/ImfTiledMisc.cpp
@@ -301,10 +301,8 @@ calculateNumTiles (int *numTiles,
 {
     for (int i = 0; i < numLevels; i++)
     {
-        int l = levelSize (min, max, i, rmode);
-        if (l > std::numeric_limits<int>::max() - size + 1)
-            throw IEX_NAMESPACE::ArgExc ("Invalid size.");
-
+        // use 64 bits to avoid int overflow if size is large.
+        Int64 l = levelSize (min, max, i, rmode);
         numTiles[i] = (l + size - 1) / size;
     }
 }