Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Env variables #173

Conversation

apoorvkhare07
Copy link
Contributor

This PR initiates work on #131 by adding reference documentation for commonly used environment variables and tokens.

@@ -6,3 +6,7 @@ date: 2019-02-22
description: >
Guides for system admins deploying OpenCue components and installing dependencies
---

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this PR includes changes from one of your other branches. I'm guessing that you may have created the env_variables branch not from master, but from another work branch?

You should clean up your branch to make sure it only includes changes relevant to this PR. You might want to create a new, clean branch from master and cherry-pick the relevant commits from env_variables to the new branch.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes @bcipriano, actually I had an open PR from master at the time I created this PR, thus this issue arise.
I'll cherry pick the changes to a new branch and make a new PR accordingly.

@apoorvkhare07
Copy link
Contributor Author

@bcipriano I have opened a new PR #177 after making the. changes. So I think we can close this PR.

@bcipriano bcipriano closed this Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants