-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable xges unit tests on all platform/python versions #894
Enable xges unit tests on all platform/python versions #894
Conversation
1ca9328
to
94df91c
Compare
cc @ssteinbach |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, just one question about the import. Thanks for the quick turnaround time!
setup.py
Outdated
@@ -54,6 +54,7 @@ class _Ctx(object): | |||
|
|||
INSTALL_REQUIRES = [ | |||
'pyaaf2==1.4.0', | |||
'future', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this to enable the builtins
module only in python2? If so note that on line 59 there are some python2 specific dependencies, this could go there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is needed for both python2 and python3.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And sorry to not answer last week, I was away. Also I think it was simpler to do it the way we did it in the end :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like its in python3: https://docs.python.org/3/library/builtins.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a comment saying "# enables the builtins module on python2"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My one request is that this gets a comment in the setup.py
noting that this is for the builtins module specifically used by the XGES adapter. Otherwise looks great, thanks for the quick turnaround time!
94df91c
to
b2c048d
Compare
Fixing minor confusion between int and longs
b2c048d
to
77d851f
Compare
Thanks for the review! |
After #873 was merged, this enables xges adapter tests on the same platforms/python version as other adapters.