Enable xges unit tests on all platform/python versions #894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiblahute
force-pushed
the
xges_test_windows_py2
branch
4 times, most recently
from
1ca9328
to
94df91c
Compare
|
cc @ssteinbach |
ssteinbach
reviewed
Feb 23, 2021
setup.py
Outdated
| @@ -54,6 +54,7 @@ class _Ctx(object): | |||
|
|
|||
| INSTALL_REQUIRES = [ | |||
| 'pyaaf2==1.4.0', | |||
| 'future', | |||
There was a problem hiding this comment.
Is this to enable the builtins module only in python2? If so note that on line 59 there are some python2 specific dependencies, this could go there.
There was a problem hiding this comment.
I think it is needed for both python2 and python3.
There was a problem hiding this comment.
And sorry to not answer last week, I was away. Also I think it was simpler to do it the way we did it in the end :-)
There was a problem hiding this comment.
Looks like its in python3: https://docs.python.org/3/library/builtins.html
There was a problem hiding this comment.
Could you add a comment saying "# enables the builtins module on python2"
ssteinbach
requested changes
Feb 23, 2021
thiblahute
force-pushed
the
xges_test_windows_py2
branch
from
94df91c
to
b2c048d
Compare
Fixing minor confusion between int and longs
thiblahute
force-pushed
the
xges_test_windows_py2
branch
from
b2c048d
to
77d851f
Compare
ssteinbach
approved these changes
Feb 24, 2021
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #873 was merged, this enables xges adapter tests on the same platforms/python version as other adapters.