Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quiet the aaf adapter test to clean up test output #893

Merged

Conversation

ssteinbach
Copy link
Collaborator

The AAF adapter had a unit test that was printing to stdout. This test quiets that output and checks the result against an expected string.

@ssteinbach ssteinbach added this to the Public Beta 14 milestone Feb 20, 2021
@codecov-io
Copy link

Codecov Report

Merging #893 (4148e84) into master (6ed3b56) will decrease coverage by 0.47%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #893      +/-   ##
==========================================
- Coverage   86.65%   86.18%   -0.48%     
==========================================
  Files         183      183              
  Lines       17879    17705     -174     
  Branches     1972     1972              
==========================================
- Hits        15493    15259     -234     
- Misses       1902     1948      +46     
- Partials      484      498      +14     
Flag Coverage Δ
unittests 86.18% <100.00%> (-0.40%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...elineio_contrib/adapters/tests/test_aaf_adapter.py 98.21% <100.00%> (+0.04%) ⬆️
tests/test_plugin_detection.py 84.31% <0.00%> (-9.81%) ⬇️
...lineio_contrib/adapters/tests/test_fcpx_adapter.py 89.74% <0.00%> (-6.46%) ⬇️
...-opentimelineio/opentimelineio/core/_core_utils.py 79.07% <0.00%> (-5.22%) ⬇️
...-opentimelineio/opentimelineio/console/otiostat.py 67.81% <0.00%> (-3.62%) ⬇️
...-opentimelineio/opentimelineio/adapters/adapter.py 87.12% <0.00%> (-1.99%) ⬇️
contrib/opentimelineio_contrib/adapters/xges.py 79.21% <0.00%> (-1.84%) ⬇️
...ntimelineio/opentimelineio-bindings/otio_tests.cpp 71.92% <0.00%> (-1.76%) ⬇️
...ineio_contrib/adapters/tests/tests_xges_adapter.py 90.65% <0.00%> (-1.19%) ⬇️
...ontrib/opentimelineio_contrib/adapters/kdenlive.py 82.23% <0.00%> (-1.16%) ⬇️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ed3b56...4148e84. Read the comment docs.

@ssteinbach ssteinbach changed the title quiet the adapter test to clean up test output quiet the aaf adapter test to clean up test output Feb 22, 2021
@ssteinbach ssteinbach merged commit 84c8245 into AcademySoftwareFoundation:master Feb 24, 2021
@ssteinbach ssteinbach deleted the quiet_aaf_tests branch February 24, 2021 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants