Address big integers bug #892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reinecke
reviewed
Feb 20, 2021
|
I'm hoping to not do that in this PR... I think that entails a bunch of other small changes to true the whole class up to |
|
Ahh, gotcha. Sounds good. |
meshula
requested changes
Feb 22, 2021
- to remove integer ambiguity around 32/64bit integers, we coerce all ints to int64_t.
- When a uint64_t is serialized, it is bitwise & with INT64_MAX first to avoid overflowing the integer. In order to do that comparison at serialization time, the uint64_t needs to be stored as a uint64_t all the way through the python bindings into the any mapping. - the next step is to move the & operation up into the python bindings and prevent people from storing invalid numbers in OTIO files.
Please enter the commit message for your changes. Lines starting
- this is to allow parity with the values in python files
- add support in the serializer/deserializer for NaN, Inf, -Infinity etc from rapidjson - block pybind11 from automatically casting numbers that don't fit into double or int64_t into bool - add a unit test and test data to test the serialization and behavior
- Adds specific messages that test if something is an out of range integer, or an invalid type - includes a list of supported types
ssteinbach
commented
Mar 2, 2021
meshula
approved these changes
Mar 2, 2021
- The 'Writer' part of SerializableObject needed the same tightening as the RapidJSON dispatcher - this is used for things that serialize and compare JSON (like cloning and the `is_equivalent_to` method. - Because the ImageSequenceReference schema has `int` in it (which should at some point be changed to int64_t), it was tripping this check on certain platforms
reinecke
approved these changes
Mar 2, 2021
Codecov Report
@@ Coverage Diff @@
## master #892 +/- ##
==========================================
- Coverage 86.15% 86.10% -0.05%
==========================================
Files 183 184 +1
Lines 17719 17850 +131
Branches 1970 1982 +12
==========================================
+ Hits 15265 15369 +104
- Misses 1956 1977 +21
- Partials 498 504 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #884
int64_tboolint64_tdouble(includingNaN,Inf,-Infinitysupport)SerializableObjectRationalTime,TimeTransformandTimeRangeTypeError: A value of type '<type 'set'>' is incompatible with OpenTimelineIO. OpenTimelineIO only supports the following value types in AnyDictionary containers (like the .metadata dictionary): ('int', 'float', 'str', 'bool', 'list', 'dictionary', 'opentime.RationalTime', 'opentime.TimeRange', 'opentime.TimeTransform').ValueError: A value of 36893488147419103232 is outside of the range of integers that OpenTimelineIO supports, [-9223372036854775808, 9223372036854775807], which is the range of C++ int64_t.TODO: