AAF Writer: Making precheck() more robust #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freesonluxo
force-pushed
the
freeson-otio-484
branch
from
964d928
to
3861494
Compare
…ng new error type AAFValidationError and raising it.
Codecov Report
@@ Coverage Diff @@
## master #512 +/- ##
==========================================
+ Coverage 88.37% 88.54% +0.16%
==========================================
Files 68 68
Lines 6969 6981 +12
==========================================
+ Hits 6159 6181 +22
+ Misses 810 800 -10
Continue to review full report at Codecov.
|
|
Perhaps I should add a negative test that actually fails the precheck here. |
jminor
approved these changes
May 7, 2019
ssteinbach
approved these changes
May 7, 2019
|
Hm. I'd like to check some more things before pushing this. Can we pause on this for now? |
ssteinbach
approved these changes
May 8, 2019
|
Actually, I think I might have jumped the gun thinking my code was causing issues. It was user error. This is ready to be pushed! |
ssteinbach
pushed a commit
to ssteinbach/OpenTimelineIO
that referenced
this pull request
Jun 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #484 (not fixing it, but making the failure more elegant).
The validate_metadata() function requires access and verification of certain fields in objects that may or not be there. I thought that using a "promise" like pattern led to a much more elegant, robust result. Hopefully this isn't too much overkill, it does allow our precheck to be a lot more expressive.