-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added otiotool --remove-metadata-key option #1642
Added otiotool --remove-metadata-key option #1642
Conversation
Signed-off-by: Joshua Minor <[email protected]>
Signed-off-by: Joshua Minor <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1642 +/- ##
==========================================
- Coverage 79.91% 79.83% -0.08%
==========================================
Files 197 197
Lines 21731 21753 +22
Branches 4339 4350 +11
==========================================
+ Hits 17366 17367 +1
- Misses 2213 2233 +20
- Partials 2152 2153 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I read this correctly it will only remove a key from the "top level" of a metadata dict.
I believe this will suffice in most cases, but we should perhaps mention this in the docs?
Signed-off-by: Joshua Minor <[email protected]>
@apetrynet I addressed your note about "top level" in the usage statement. Does that look good to you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me @jminor
I also like the more verbose help strings in the other arguments.
This PR adds a new
--remove-metadata-key
feature tootiotool
. If specified, this option looks for the given metadata key(s) on all objects in the OTIO and removes it when found. This could be used to remove private, sensitive, or extraneous metadata from an OTIO.This PR also improves the
otiotool
usage docs, adding some examples, clarifying some arguments, and making the short summary more readable by using the--long-options
instead of single-letter options.