Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a bug in the docs for using schema downgrading #1641

Merged
merged 2 commits into from
Jul 22, 2023

Conversation

ssteinbach
Copy link
Collaborator

The documentation left out a required argument for using the downgrading system from python in one of its examples. Also clarifies how to get core schemas from python.

@ssteinbach ssteinbach added this to the Public Beta 16 milestone Jul 21, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2023

Codecov Report

Merging #1641 (85e13f8) into main (45c6cfd) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1641      +/-   ##
==========================================
- Coverage   79.91%   79.91%   -0.01%     
==========================================
  Files         197      197              
  Lines       21731    21731              
  Branches     4339     4339              
==========================================
- Hits        17367    17366       -1     
  Misses       2213     2213              
- Partials     2151     2152       +1     
Flag Coverage Δ
py-unittests 79.91% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45c6cfd...85e13f8. Read the comment docs.

Copy link
Collaborator

@meshula meshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Co-authored-by: Jean-Christophe Morin <[email protected]>
Signed-off-by: Stephan Steinbach <[email protected]>
@meshula meshula merged commit eaf8569 into AcademySoftwareFoundation:main Jul 22, 2023
38 checks passed
MichaelPlug pushed a commit to MichaelPlug/OpenTimelineIO that referenced this pull request Aug 5, 2023
…undation#1641)

* fix a bug in the docs for using schema downgrading
* Update docs/tutorials/versioning-schemas.md

Co-authored-by: Jean-Christophe Morin <[email protected]>
Signed-off-by: Stephan Steinbach <[email protected]>
Signed-off-by: Michele Spina <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants