[Breaking change] Remove support for passing a None value as the name argument #1453
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove support for passing a None value as the name argument to Marker, Track, Stack and MissingReference constructors
Follow up to #1446.
As discussed in the last TSC meeting, it has been agreed that we shuld keep the class constructors consistent, which mean that we should drop the ability to pass None values for the name argument of the
Marker
,Track
,Stack
andMissingReference
class constructors.Passing None is bad in this case because it's inconsistent with the other constructors, which can be seen as not user friendly.
The
name
parameter is always defined as a kwarg with a default value of''
(empty string). This means that it's still possible to ignore the name parameter entirely when instantiating a class. The only difference now is that the type will be explicitly exposed (and discoverable) and if something else than a string is passed as an argument, it will cause an exception like this:This is considered a breaking change and should be clearly marked as such in the changelog.