-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Plugin schema execution_scope
parameter
#1428
Remove Plugin schema execution_scope
parameter
#1428
Conversation
execution_scope
parameterexecution_scope
parameter
d86a6f7
to
7a218f0
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1428 +/- ##
==========================================
- Coverage 86.38% 86.38% -0.01%
==========================================
Files 201 201
Lines 20860 20854 -6
Branches 2298 2298
==========================================
- Hits 18020 18014 -6
Misses 2244 2244
Partials 596 596
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Are there knock-on affects to adapters outside of this repository? i.e. is it possible there are external callers to MediaLinker that might need to modify source with one less parameter?
I've tested against our proprietary plugin set and it looks good, trying to find an additional tester. |
Tested externally now, looks good there too (thanks @apetrynet and @reinecke). |
…dation#1428) * remove execution_scope from OTIO * add type hints to media linker code samples Co-authored-by: ssteinbach <[email protected]> Signed-off-by: Michele Spina <[email protected]>
When the plugin system was originally designed for the adapter system, the idea was that adapters could be implemented in other languages by sub shelling out. It was simpler to implement that directly via the
extern_*
pattern seen in the RV and Maya adapters, and now the library is emphasizing native support. This feature was never implemented, so this PR removes the parameter from the library.This PR follows #1395
Closes #728