Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Plugin schema execution_scope parameter #1428

Merged

Conversation

ssteinbach
Copy link
Collaborator

@ssteinbach ssteinbach commented Sep 28, 2022

When the plugin system was originally designed for the adapter system, the idea was that adapters could be implemented in other languages by sub shelling out. It was simpler to implement that directly via the extern_* pattern seen in the RV and Maya adapters, and now the library is emphasizing native support. This feature was never implemented, so this PR removes the parameter from the library.

This PR follows #1395

Closes #728

@ssteinbach ssteinbach added this to the Public Beta 16 milestone Sep 28, 2022
@ssteinbach ssteinbach changed the title Remove plugin execution_scope parameter Remove Plugin schema execution_scope parameter Sep 28, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1428 (7a218f0) into main (41ceb58) will decrease coverage by 0.00%.
The diff coverage is 83.33%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1428      +/-   ##
==========================================
- Coverage   86.38%   86.38%   -0.01%     
==========================================
  Files         201      201              
  Lines       20860    20854       -6     
  Branches     2298     2298              
==========================================
- Hits        18020    18014       -6     
  Misses       2244     2244              
  Partials      596      596              
Flag Coverage Δ
py-unittests 86.38% <83.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...-opentimelineio/opentimelineio/adapters/adapter.py 89.00% <ø> (ø)
...timelineio/opentimelineio/plugins/python_plugin.py 88.88% <ø> (-0.35%) ⬇️
tests/test_adapter_plugin.py 87.75% <ø> (-0.09%) ⬇️
tests/test_hooks_plugins.py 97.72% <ø> (-0.06%) ⬇️
tests/test_media_linker.py 95.65% <ø> (-0.10%) ⬇️
...-opentimelineio/opentimelineio/schema/schemadef.py 94.73% <50.00%> (ø)
src/py-opentimelineio/opentimelineio/hooks.py 100.00% <100.00%> (ø)
...c/py-opentimelineio/opentimelineio/media_linker.py 83.33% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41ceb58...7a218f0. Read the comment docs.

Copy link
Collaborator

@meshula meshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Are there knock-on affects to adapters outside of this repository? i.e. is it possible there are external callers to MediaLinker that might need to modify source with one less parameter?

@ssteinbach
Copy link
Collaborator Author

ssteinbach commented Sep 30, 2022

I've tested against our proprietary plugin set and it looks good, trying to find an additional tester.

@ssteinbach
Copy link
Collaborator Author

Tested externally now, looks good there too (thanks @apetrynet and @reinecke).

@meshula meshula merged commit 531edf5 into AcademySoftwareFoundation:main Sep 30, 2022
@ssteinbach ssteinbach deleted the main.remove_execution_scope branch September 30, 2022 22:08
MichaelPlug pushed a commit to MichaelPlug/OpenTimelineIO that referenced this pull request Aug 5, 2023
…dation#1428)

* remove execution_scope from OTIO
* add type hints to media linker code samples

Co-authored-by: ssteinbach <[email protected]>
Signed-off-by: Michele Spina <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove execution_scope field
3 participants