fcp_xml: serialize marker out value instead of -1 #1411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Signed-off-by: Jeff Horrocks <[email protected]>
jhorrocks-tl
force-pushed
the
fcpxml_support_marker_out
branch
from
bc0e988
to
a53b531
Compare
reinecke
approved these changes
Sep 23, 2022
|
Hey @reinecke, sorry for the wait. We've emailed in the signed CLA. |
|
@reinecke FYI, I just unblocked the CLA check. Feel free to merge whenever you get a chance. Thanks again! |
|
@jhorrocks-tl thank you! |
ssteinbach
changed the title
MichaelPlug
pushed a commit
to MichaelPlug/OpenTimelineIO
that referenced
this pull request
Aug 5, 2023
…ndation#1411) Signed-off-by: Jeff Horrocks <[email protected]> Signed-off-by: Michele Spina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1410
This PR removes the hardcoded -1 when serializing markers with duration to FCP XML. Now the out value for markers will be
marked_range.start_time.value + marked_range.duration.value.I modified the existing test
test_fcp7_xml_adapter.test_roundtrip_mem2disk2mem, adding both timeline and clip markers that have durations.