feat(jpeg): Support reading Ultra HDR images #4484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgritz
requested changes
Oct 10, 2024
lgritz
reviewed
Oct 10, 2024
mugulmd
force-pushed
the
jpeg-ultrahdr
branch
3 times, most recently
from
ac8f6b7
to
5c0698e
Compare
|
@lgritz quick question: I will need to add at least one Ultra HDR image for the test suite. The ones I use for testing locally weigh a bit more than 2M. Should I add them directly to the OpenImageIO repo, or should I create a PR in OpenImageIO-images to add them there ? |
|
Images repo, please |
mugulmd
force-pushed
the
jpeg-ultrahdr
branch
from
cb6b890
to
e3049ae
Compare
mugulmd
force-pushed
the
jpeg-ultrahdr
branch
19 times, most recently
from
b87bd9b
to
960cc35
Compare
lgritz
reviewed
Oct 18, 2024
mugulmd
force-pushed
the
jpeg-ultrahdr
branch
from
8c13955
to
e8f2fe1
Compare
Signed-off-by: loicvital <[email protected]>
Signed-off-by: loicvital <[email protected]>
…ions Signed-off-by: loicvital <[email protected]>
Signed-off-by: loicvital <[email protected]>
Signed-off-by: loicvital <[email protected]>
Signed-off-by: loicvital <[email protected]>
Signed-off-by: loicvital <[email protected]>
Signed-off-by: loicvital <[email protected]>
Signed-off-by: loicvital <[email protected]>
Signed-off-by: loicvital <[email protected]>
Signed-off-by: loicvital <[email protected]>
Signed-off-by: loicvital <[email protected]>
… macro Signed-off-by: loicvital <[email protected]>
Signed-off-by: loicvital <[email protected]>
Signed-off-by: loicvital <[email protected]>
Signed-off-by: loicvital <[email protected]>
Signed-off-by: loicvital <[email protected]>
Signed-off-by: loicvital <[email protected]>
mugulmd
force-pushed
the
jpeg-ultrahdr
branch
from
e8f2fe1
to
3061eeb
Compare
|
Alright @lgritz I think we're good to go. Thanks for the review(s) :) |
lgritz
approved these changes
Nov 6, 2024
|
There's still quite a few features from libuhdr we could expose in oiio, but yeah that felt like a pretty good starting point ! |
lgritz
pushed a commit
to lgritz/OpenImageIO
that referenced
this pull request
Nov 10, 2024
…on#4484) Initial feature request: AcademySoftwareFoundation#4424 Add support in the `jpeg` plugin for reading Ultra HDR images using the reference codec `libultrahdr`: https://github.com/google/libultrahdr In short, "ultra hdr" images are a clever extension of JPEG where the image file really is an old school JPEG file and will be interpreted correctly as such by old readers not aware of ultra hdr, but readers that are aware will see an extra piece of metadata that contains a gain map, that when applied to the base layer then yields an HDR image. Pretty clever approach! Images used for testing during development: https://github.com/MishaalRahmanGH/Ultra_HDR_Samples --------- Signed-off-by: loicvital <[email protected]>
lgritz
pushed a commit
to lgritz/OpenImageIO
that referenced
this pull request
Nov 10, 2024
…on#4484) Initial feature request: AcademySoftwareFoundation#4424 Add support in the `jpeg` plugin for reading Ultra HDR images using the reference codec `libultrahdr`: https://github.com/google/libultrahdr In short, "ultra hdr" images are a clever extension of JPEG where the image file really is an old school JPEG file and will be interpreted correctly as such by old readers not aware of ultra hdr, but readers that are aware will see an extra piece of metadata that contains a gain map, that when applied to the base layer then yields an HDR image. Pretty clever approach! Images used for testing during development: https://github.com/MishaalRahmanGH/Ultra_HDR_Samples --------- Signed-off-by: loicvital <[email protected]>
lgritz
pushed a commit
to lgritz/OpenImageIO
that referenced
this pull request
Nov 13, 2024
…on#4484) Initial feature request: AcademySoftwareFoundation#4424 Add support in the `jpeg` plugin for reading Ultra HDR images using the reference codec `libultrahdr`: https://github.com/google/libultrahdr In short, "ultra hdr" images are a clever extension of JPEG where the image file really is an old school JPEG file and will be interpreted correctly as such by old readers not aware of ultra hdr, but readers that are aware will see an extra piece of metadata that contains a gain map, that when applied to the base layer then yields an HDR image. Pretty clever approach! Images used for testing during development: https://github.com/MishaalRahmanGH/Ultra_HDR_Samples --------- Signed-off-by: loicvital <[email protected]>
lgritz
pushed a commit
to lgritz/OpenImageIO
that referenced
this pull request
Nov 21, 2024
…on#4484) Initial feature request: AcademySoftwareFoundation#4424 Add support in the `jpeg` plugin for reading Ultra HDR images using the reference codec `libultrahdr`: https://github.com/google/libultrahdr In short, "ultra hdr" images are a clever extension of JPEG where the image file really is an old school JPEG file and will be interpreted correctly as such by old readers not aware of ultra hdr, but readers that are aware will see an extra piece of metadata that contains a gain map, that when applied to the base layer then yields an HDR image. Pretty clever approach! Images used for testing during development: https://github.com/MishaalRahmanGH/Ultra_HDR_Samples --------- Signed-off-by: loicvital <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Initial feature request: #4424
Add support in the
jpegplugin for reading Ultra HDR images using the reference codeclibultrahdr: https://github.com/google/libultrahdrTests
Images used for testing during development: https://github.com/MishaalRahmanGH/Ultra_HDR_Samples
Checklist:
need to update the documentation, for example if this is a bug fix that
doesn't change the API.)
(adding new test cases if necessary).
corresponding Python bindings (and if altering ImageBufAlgo functions, also
exposed the new functionality as oiiotool options).
already run clang-format before submitting, I definitely will look at the CI
test that runs clang-format and fix anything that it highlights as being
nonconforming.