-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(jpeg): Support reading Ultra HDR images #4484
base: main
Are you sure you want to change the base?
Conversation
|
ac8f6b7
to
5c0698e
Compare
@lgritz quick question: I will need to add at least one Ultra HDR image for the test suite. The ones I use for testing locally weigh a bit more than 2M. Should I add them directly to the OpenImageIO repo, or should I create a PR in OpenImageIO-images to add them there ? |
Images repo, please |
cb6b890
to
e3049ae
Compare
b87bd9b
to
960cc35
Compare
What's happening with icc is that the libuhdr's build is passing parameters to the compiler that it doesn't recognize. Its build system probably assumes that if it's building on Linux, it must be either gcc or clang. But icc doesn't take those particular arguments. I think the easiest thing is to just set the icc test (in ci.yml) to disable the use of libuhdr by adding to its |
Signed-off-by: loicvital <[email protected]>
Signed-off-by: loicvital <[email protected]>
…ions Signed-off-by: loicvital <[email protected]>
Signed-off-by: loicvital <[email protected]>
Signed-off-by: loicvital <[email protected]>
960cc35
to
3e8c788
Compare
Signed-off-by: loicvital <[email protected]>
Signed-off-by: loicvital <[email protected]>
Signed-off-by: loicvital <[email protected]>
Signed-off-by: loicvital <[email protected]>
Signed-off-by: loicvital <[email protected]>
Signed-off-by: loicvital <[email protected]>
Signed-off-by: loicvital <[email protected]>
… macro Signed-off-by: loicvital <[email protected]>
3e8c788
to
cbc301e
Compare
Signed-off-by: loicvital <[email protected]>
cbc301e
to
05776cc
Compare
Once I get the CLA authorized by my company I'll be able to merge the PR containing the test image and then I'll re-introduce the test case in the test suite :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
We'll leave this pending the CLA and adding a proper test including source in OpenImageIO-images. When those items are completed, I think it's ready to merge.
Description
Initial feature request: #4424
Add support in the
jpeg
plugin for reading Ultra HDR images using the reference codeclibultrahdr
: https://github.com/google/libultrahdrTests
Images used for testing during development: https://github.com/MishaalRahmanGH/Ultra_HDR_Samples
Checklist:
need to update the documentation, for example if this is a bug fix that
doesn't change the API.)
(adding new test cases if necessary).
corresponding Python bindings (and if altering ImageBufAlgo functions, also
exposed the new functionality as oiiotool options).
already run clang-format before submitting, I definitely will look at the CI
test that runs clang-format and fix anything that it highlights as being
nonconforming.