Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Python wheels workflow and build backend #4428
base: main
Are you sure you want to change the base?
feat: Python wheels workflow and build backend #4428
Changes from 178 commits
d8e0955
df83fc8
5e86b2d
ea2432a
5c1a1b8
78fed97
bd271a3
d298bad
f9d7f21
f555161
5f70b0a
3337f70
50f0b4e
2013d09
7180872
1997724
80acc8c
2ee72cd
0f5e1a3
13f60ce
b96525e
42caf75
5a70d3e
151333f
0810544
bf4265e
1c7cd37
ea63dbb
781ee80
6eddaf5
5ca303d
3599081
2db7b90
2c10095
a7c8fd8
c4b6bb0
25df0aa
a1d809b
1f45b2f
becb6e8
0eedbcb
ef615c8
87d2e70
3122823
ce0b5b8
660d068
9db71c5
bd12ec9
1a0adf6
f27f092
cad150d
d8ad61f
14f7bb0
066e571
8289357
087605a
9e5d1e5
acb513a
f784415
22dfb86
1c3370e
9818a04
6384b5d
11e84e6
e1fc73f
e19ab97
a8362ad
be9027f
1ddddd8
f4f5ee8
9e40cb0
36c5275
5397de1
68c5497
e3f07e1
c18d241
d85dfc8
d719823
0505040
318e4ff
4c91126
4ef5553
edff8a6
245c51e
e52c3cf
6d25552
16793db
edda093
f465ba5
d0adf3a
d6872e5
5904090
3cbb73d
0fdace1
0160971
35210f1
889e46d
f5e118d
16d634e
ce5db05
ab7e348
ffa522e
1258db1
5dc9ceb
2a5e713
59787c2
72402d2
c313ad3
36a4d29
f21a834
18d192f
fb677f4
37fbfa3
25a6ed7
e9e3197
d214039
77b7436
25d774c
7e9e687
e45ca15
5f76706
c6c25a4
3a3deee
1e05f5d
e6f818b
5f4caf5
6b2fb9f
af99af9
bf451a5
b2a1e4d
31cc8f0
9f6aedf
130a108
3903ef2
a0af477
35b4af6
bfae087
77fcc6b
a615763
b13a055
b4b1269
5bba64d
7b37f05
6f61f63
d07cbe8
853952e
cf648f2
221e4d8
1036870
a882bcf
c5ded6f
63c7b56
1fba61d
f10ecfa
7a56416
db440e9
978e8f0
d45e634
deeba08
9fa0a76
380e8c8
34d7e3a
494a53c
9d0645d
d9b37c0
110e69a
5373e98
b13051d
82053dd
9437415
3e60ade
a3fd5ea
f63dbfb
f98635f
8fdc0d5
3524c4f
babfa59
6d8ceb5
2fed38e
678f530
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is kind of reverting what was made before. You could pass
-DCMAKE_INSTALL_RPATH
on a per platform basis instead.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, before, I think CMAKE_INSTALL_RPATH was defaulting to an absolute path; whereas now, it uses loader-path-relative defaults. We could still pass the option on a per-platform basis, but I'm not sure how that would be advantageous...?