build: Remove boost::stacktrace #4222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To shed the boost dependency, we are disabling stacktrace for now. It's not vital and probably not worth keeping boost just for that. C++23 has std::stacktrace, so as compilers add support for this, we will phase it back in. We can also add it back if somebody has an alternate suggestion for a 3rd party solution that is a simply drop-in replacement, portable, lightweight dependency, with compatible license. A good compromise might be this one: https://github.com/jeremy-rifkin/cpptrace But I think what I'm proposing is that we accept this PR first, get rid of boost, then we can come back to looking at cpptrace as potentially a way to restore the functionality prior to C++23. Signed-off-by: Larry Gritz <[email protected]>
lgritz
merged commit ab87887
into
AcademySoftwareFoundation:master
23 of 24 checks passed
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Apr 13, 2024
To shed the boost dependency, we are disabling stacktrace for now. It's not vital and probably not worth keeping boost just for that. C++23 has std::stacktrace, so as compilers add support for this, we will phase it back in. We can also add it back if somebody has an alternate suggestion for a 3rd party solution that is a simply drop-in replacement, portable, lightweight dependency, with compatible license. A good compromise might be this one: https://github.com/jeremy-rifkin/cpptrace But I think what I'm proposing is that we accept this PR first, get rid of boost, then we can come back to looking at cpptrace as potentially a way to restore the functionality prior to C++23. Signed-off-by: Larry Gritz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To shed the boost dependency, we are disabling stacktrace for now. It's not vital and probably not worth keeping boost just for that.
C++23 has std::stacktrace, so as compilers add support for this, we will phase it back in.
We can also add it back if somebody has an alternate suggestion for a 3rd party solution that is a simply drop-in replacement, portable, lightweight dependency, with compatible license. A good compromise might be this one: https://github.com/jeremy-rifkin/cpptrace But I think what I'm proposing is that we accept this PR first, get rid of boost, then we can come back to looking at cpptrace as potentially a way to restore the functionality prior to C++23.