feat(oiiotool): Allow decision making about fixnan #4171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a new bit of pseudo-metadata that can be retrieved by oiiotool's
expression substitution: `{TOP.NONFINITE_COUNT}` will be replaced by
the count of inf and nan values present in the top image.
Also, the `-fixnan` command now has the side effect of setting a user
variable called `NONFINITE_COUNT` to the number of nonfinite values that
were detected or repaired.
Between the two of these, it's now easy to solve the following problem that
actually came up in production for us.
Sometimes, nans creep into images, and it's easier to repair them than
to fix the complicated process that produced them in the first
place. For some process in the studio, we had a script that was doing
this preemptively on every image it encountered:
oiiotool image.exr -fixnan black -o image.exr
It was very expensive to repair every image whether it needed it or
not, when actually it's only needed once every
many-thousands-of-images. Most of the expense was in outputting the
repaired file overtop the original. Now we can do this
oiiotool image.exr -if "{TOP.NONFINITE_COUNT}" -fixnan black -o image.exr -endif
It still has to read the image and look for NaN values, but since
there are almost never any actual NaN's, now for the usual case, it
can skip writing the output -- which was the vast majority of time.
Signed-off-by: Larry Gritz <[email protected]>
lgritz
added
enhancement
grdanny
approved these changes
Mar 5, 2024
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Mar 5, 2024
…undation#4171) Added a new bit of pseudo-metadata that can be retrieved by oiiotool's expression substitution: `{TOP.NONFINITE_COUNT}` will be replaced by the count of inf and nan values present in the top image. Also, the `-fixnan` command now has the side effect of setting a user variable called `NONFINITE_COUNT` to the number of nonfinite values that were detected or repaired. Between the two of these, it's now easy to solve the following problem that actually came up in production for us. Sometimes, nans creep into images, and it's easier to repair them than to fix the complicated process that produced them in the first place. For some process in the studio, we had a script that was doing this preemptively on every image it encountered: oiiotool image.exr -fixnan black -o image.exr It was very expensive to repair every image whether it needed it or not, when actually it's only needed once every many-thousands-of-images. Most of the expense was in outputting the repaired file overtop the original. Now we can do this oiiotool image.exr -if "{TOP.NONFINITE_COUNT}" -fixnan black -o image.exr -endif It still has to read the image and look for NaN values, but since there are almost never any actual NaN's, now for the usual case, it can skip writing the output -- which was the vast majority of time. Signed-off-by: Larry Gritz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new bit of pseudo-metadata that can be retrieved by oiiotool's expression substitution:
{TOP.NONFINITE_COUNT}will be replaced by the count of inf and nan values present in the top image.Also, the
-fixnancommand now has the side effect of setting a user variable calledNONFINITE_COUNTto the number of nonfinite values that were detected or repaired.Between the two of these, it's now easy to solve the following problem that actually came up in production for us.
Sometimes, nans creep into images, and it's easier to repair them than to fix the complicated process that produced them in the first place. For some process in the studio, we had a script that was doing this preemptively on every image it encountered:
It was very expensive to repair every image whether it needed it or not, when actually it's only needed once every
many-thousands-of-images. Most of the expense was in outputting the repaired file overtop the original. Now we can do this
It still has to read the image and look for NaN values, but since there are almost never any actual NaN's, now for the usual case, it can skip writing the output -- which was the vast majority of time.