build: Better cmake verbose behavior #4037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we bumped to cmake 3.15 minimum for 2.5, we changed lots of
constructs like this:
if (VERBOSE)
message (STATUS "blah")
endif ()
to this:
message (VERBOSE "blah")
but I didn't realize that this was not enough, and to do it right
requires CMAKE_MESSAGE_LOG_LEVEL. So even when VERBOSE=ON, we weren't
actually getting all the verbose messages. Here, we fix it.
Also, when verbose, print the list of C++ compile features that cmake
discovers.
Signed-off-by: Larry Gritz <[email protected]>
|
No objections -> merging |
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Nov 16, 2023
When we bumped to cmake 3.15 minimum for 2.5, we changed lots of
constructs like this:
if (VERBOSE)
message (STATUS "blah")
endif ()
to this:
message (VERBOSE "blah")
but I didn't realize that this was not enough, and to do it right
requires CMAKE_MESSAGE_LOG_LEVEL. So even when VERBOSE=ON, we weren't
actually getting all the verbose messages. Here, we fix it.
Also, when verbose, print the list of C++ compile features that cmake
discovers.
Signed-off-by: Larry Gritz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we bumped to cmake 3.15 minimum for 2.5, we changed lots of constructs like this:
to this:
but I didn't realize that this was not enough, and to do it right requires CMAKE_MESSAGE_LOG_LEVEL. So even when VERBOSE=ON, we weren't actually getting all the verbose messages. Here, we fix it.
Also, when verbose, print the list of C++ compile features that cmake discovers.