Fix float128 compilation of NVPTX backend for LLVM #3823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgritz
approved these changes
Apr 28, 2023
lgritz
pushed a commit
to lgritz/OpenImageIO
that referenced
this pull request
Apr 30, 2023
…undation#3823) The latest version of libfmt began using the `__float128` type but this is [not supported in the NVPTX backend for LLVM](https://discourse.llvm.org/t/compiling-cuda-code-fails/61240/13). A way to detect this particular platform seems to be to check both `__CUDA_ARCH__` and `__clang__`. I am not disabling it entirely on any CUDA target because NVCC 10+ understands `_float128` and generates instructions for it when tested on godbolt. Following up from AcademySoftwareFoundation#3809. Co-authored-by: Edoardo Dominici <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The latest version of libfmt began using the
__float128type but this is not supported in the NVPTX backend for LLVM. A way to detect this particular platform seems to be to check both__CUDA_ARCH__and__clang__.I am not disabling it entirely on any CUDA target because NVCC 10+ understands
_float128and generates instructions for it when tested on godbolt.Following up from #3809.
Checklist: