fix(targa): guard against corrupted tga files #3768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Be more careful constructing strings from what we read in the header; corrupted files may make them not be zero-terminated. Fixes TALOS-2023-1707 / CVE-2023-24473 * Watch out for pixels with palette indices that exceed the size we allocated for the palette. Fixes TALOS-2023-1708 / CVE-2023-22845 * Check alpha_type for valid range.
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Feb 10, 2023
…ion#3768) * Be more careful constructing strings from what we read in the header; corrupted files may make them not be zero-terminated. Fixes TALOS-2023-1707 / CVE-2023-24473 * Watch out for pixels with palette indices that exceed the size we allocated for the palette. Fixes TALOS-2023-1708 / CVE-2023-22845 * Check alpha_type for valid range.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be more careful constructing strings from what we read in the header; corrupted files may make them not be zero-terminated. Fixes TALOS-2023-1707 / CVE-2023-24473
Watch out for pixels with palette indices that exceed the size we allocated for the palette. Fixes TALOS-2023-1708 / CVE-2023-22845
Check alpha_type for valid range.