IFF output safety #3676
Merged
IFF output safety #3676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Maya IFF documentation says IFF file has max resolution of 8192, and our implementation only allows writing RGB and RGBA, so check these limits when an IFF file is opened for output. * Make sure scratch space allocates enough for tile padding. * Check for non-zero image origin coordinates (which are not allowed in IFF files). * Change some 16-bit loop variables to uint32_t to avoid possible overflow. Fixes TALOS-2022-1654, TALOS-2022-1655, TALOS-2022-1656
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Nov 21, 2022
* Maya IFF documentation says IFF file has max resolution of 8192, and our implementation only allows writing RGB and RGBA, so check these limits when an IFF file is opened for output. * Make sure scratch space allocates enough for tile padding. * Check for non-zero image origin coordinates (which are not allowed in IFF files). * Change some 16-bit loop variables to uint32_t to avoid possible overflow. Fixes TALOS-2022-1654, TALOS-2022-1655, TALOS-2022-1656
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maya IFF documentation says IFF file has max resolution of 8192, and our implementation only allows writing RGB and RGBA, so check these limits when an IFF file is opened for output.
Make sure scratch space allocates enough for tile padding.
Check for non-zero image origin coordinates (which are not allowed in IFF files).
Change some 16-bit loop variables to uint32_t to avoid possible overflow.
Fixes TALOS-2022-1654, TALOS-2022-1655, TALOS-2022-1656