Fix embarrassing ustring::compare(string_view) bug #2283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why not just use: return string_view(m_chars, size()).compare(str);which already has the correct logic? |
The logic was wrong in cases where the string_view was longer than the ustring, but they has the same character sequence up to the length of the ustring. Add some unit tests to ferret out this case. To do: fully flesh out unit tests for every last bit of functionality of ustring and string_view.
|
I think you're right, and I can eliminate a few other cases as well. Updated. |
|
LGTM! |
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Jul 10, 2019
…undation#2283) The logic was wrong in cases where the string_view was longer than the ustring, but they has the same character sequence up to the length of the ustring. Add some unit tests to ferret out this case. To do: fully flesh out unit tests for every last bit of functionality of ustring and string_view.
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Jul 12, 2019
…undation#2283) The logic was wrong in cases where the string_view was longer than the ustring, but they has the same character sequence up to the length of the ustring. Add some unit tests to ferret out this case. To do: fully flesh out unit tests for every last bit of functionality of ustring and string_view.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic was wrong in cases where the string_view was longer than the
ustring, but they has the same character sequence up to the length of
the ustring.
Add some unit tests to ferret out this case.
To do: fully flesh out unit tests for every last bit of functionality
of ustring and string_view.