Add dockerignore so that the sandbox env can be run mutliple times. #879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsbijl
requested review from
bcipriano,
DiegoTavares,
gregdenton,
jrray and
smith1511
as code owners
bcipriano
approved these changes
Jan 19, 2021
Exclude a few other directories as well that are not needed during docker builds. Closes AcademySoftwareFoundation#878
larsbijl
force-pushed
the
878-sandbox-docker-ignore
branch
from
4071b1d to
f577916
Compare
|
Looking at the failing Github checks, we're seeing an error from the Despite the error, the action appears to be working as intended -- it produces the list of changed files which then pass the check. But the error is causing the pipeline to show as failed. This appears to be an issue with force-pushes as mentioned in jitterbit/get-changed-files#4 and jitterbit/get-changed-files#11. Checks LGTM, so I'll force-merge this and see if we can resolve the pipeline issue separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exclude a few other directories as well that are not needed during
docker builds.
Closes #878