Cueadmin api updates #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregdenton
commented
Dec 11, 2018
gregdenton
commented
Dec 11, 2018
bcipriano
approved these changes
Dec 11, 2018
DiegoTavares
pushed a commit
that referenced
this pull request
Oct 1, 2024
**Link the Issue(s) this Pull Request is related to.** Fixes: #1519 **Summarize your change.** Use `platform.uname()` instead of `os.uname()`. They have the same result on Linux, but `os.uname()` is not available on Windows, making us unable to kill a job from this OS. **Additional information.** Linux (ubuntu 22.04.6): ``` python >>> os.uname() posix.uname_result(sysname='Linux', nodename='titan', release='6.8.0-45-generic', version='#45~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC Wed Sep 11 15:25:05 UTC 2', machine='x86_64') >>>platform.uname() uname_result(system='Linux', node='titan', release='6.8.0-45-generic', version='#45~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC Wed Sep 11 15:25:05 UTC 2', machine='x86_64') ``` Windows (11): ``` python >>> platform.uname() uname_result(system='Windows', node='StarChaser', release='10', version='10.0.22631', machine='AMD64') ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating cueadmin to work with spi_cue api changes.