[cuegui] Add support for multiple viewers #1513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lithorus
requested review from
bcipriano,
DiegoTavares and
ramonfigueiredo
as code owners
DiegoTavares
requested changes
Sep 25, 2024
DiegoTavares
approved these changes
Oct 1, 2024
DiegoTavares
merged commit 380dbfe
into
AcademySoftwareFoundation:master
12 checks passed
ramonfigueiredo
added a commit
to ramonfigueiredo/OpenCue
that referenced
this pull request
Oct 24, 2024
- Revert changes in the PR 1513, since it was not possible to change to select and view multiple jobs using a player and it was not possible to view frames using the players - See PR AcademySoftwareFoundation#1513
ramonfigueiredo
added a commit
to ramonfigueiredo/OpenCue
that referenced
this pull request
Oct 25, 2024
This fixes the changes in PR: AcademySoftwareFoundation#1513 Changes: - Fix multiple jobs and frames visualization with different viewers - Updated JobMonitorTree.py and FrameMonitorTree.py to enable select multiple jobs and multiple frames and play using the players (e.g., OpenRV, RV, Itview = SPI viewer) configured in `cuegui.yaml`, options `output_viewers` and `output_viewer_direct_cmd_call` - Enhanced cuegui.yaml to include configuration for multiple viewers. - Fix unit tests in `FrameMonitorTree_tests.py` > `test_rightClickItem()` to ensure the job attribute is set This change allows users to open multiple jobs (JobMonitorTree.py) and frames (FrameMonitorTree.py) using different configurable viewers. The option to open multiple layers (LayerMonitorTree.py) was working before and kept as it was.
ramonfigueiredo
added a commit
that referenced
this pull request
Oct 28, 2024
**Link the Issue(s) this Pull Request is related to.** [cuegui] Cannot select and play multiple jobs and frames using viewers in OpenCue: #1558 **Summarize your change.** This fixes the changes in PR: #1513 - Fix multiple jobs and frames visualization with different viewers - Updated JobMonitorTree.py and FrameMonitorTree.py to enable select multiple jobs and multiple frames and play using the players (e.g., OpenRV, RV, Itview = SPI viewer) configured in `cuegui.yaml`, options `output_viewers` and `output_viewer_direct_cmd_call` - Enhanced cuegui.yaml to include configuration for multiple viewers. - Fix unit tests in `FrameMonitorTree_tests.py` > `test_rightClickItem()` to ensure the job attribute is set This change allows users to open multiple jobs (JobMonitorTree.py) and frames (FrameMonitorTree.py) using different configurable viewers. The option to open multiple layers (LayerMonitorTree.py) was working before and kept as it was.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarize your change.
This adds support for multiple output viewers.
The
cuegui.yamloptionoutput_viewer_direct_cmd_callis still kept as a single viewer command.It also changes the way that single frames are resolved. Instead of a hardcoded padding of 4, it will use the FileSequence and FrameSet classes to resolve the frame path.
Examples:
