Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cy2024 #1416

Merged
merged 35 commits into from
Jul 23, 2024
Merged

Cy2024 #1416

merged 35 commits into from
Jul 23, 2024

Conversation

lithorus
Copy link
Contributor

@lithorus lithorus commented Jul 15, 2024

Link the Issue(s) this Pull Request is related to.
#1407

Summarize your change.
This removes support for python 2.x and upgrades pylint for python 3.10+
Some checks have been globally disabled (eg. consider-using-f-string) to limit the amount of changes needed.

Have also removed the python2 tests/linting

@DiegoTavares
Copy link
Collaborator

Great, I'm eager to finally drop python2.7!

There are tones of lint issues to fix though.

@lithorus
Copy link
Contributor Author

Great, I'm eager to finally drop python2.7!

There are tones of lint issues to fix though.

Yes, still working my way through them :)

@lithorus lithorus marked this pull request as ready for review July 16, 2024 21:06
@lithorus lithorus marked this pull request as draft July 16, 2024 23:19
@lithorus
Copy link
Contributor Author

lithorus commented Jul 17, 2024

For some reason. the cuegui tests fails with PySide6 on the CY2024 image, It's passes with CY2023 + PySide6 and the Almalinux 9 + PySide6. Generally it seems that the xvfb-run tests are having issues with newer versions of Linux.

@lithorus lithorus marked this pull request as ready for review July 21, 2024 19:15
@lithorus lithorus mentioned this pull request Jul 21, 2024
Copy link
Collaborator

@DiegoTavares DiegoTavares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, there's a substantial amount of work on this PR.

cuegui/cuegui/plugins/LogViewPlugin.py Outdated Show resolved Hide resolved
search buttons to only search within visible text.
Also it doesn't really seem to do anything.
@DiegoTavares DiegoTavares merged commit e0ffd63 into AcademySoftwareFoundation:master Jul 23, 2024
13 checks passed
@lithorus lithorus deleted the cy2024 branch July 23, 2024 20:03
n-jay pushed a commit to n-jay/OpenCue that referenced this pull request Jul 26, 2024
* Remove python < 3.7 requirements

* Update pylint to 2.17.7

* Adjust pylintrc's and ignore consider-using-f-string

* Ignore the proto modules globally for linting

* Change pylint version to 2.15.10

* Fix pylint errors on pycue, pyoutline and cueadmin

* Pylint fixed for cuegui part 1

* Fix some of the items conversions

* Pylint fixed for cuegui part 2

* Remove python2 unit tests

* Pylint fixed for cuegui part 3

* Pylint fixed for cuegui part 4

* Pylint fixed for cuesubmit

* Add more ignored proto modules

* Pylint fixed for rqd

* Add more ignored proto modules

* Pylint fixes for rqd

* Update actions/checkout to v3 to keep in line with other tests

* Revert change for FrameMonitorTree.py

* Revert some of the "consider-using-dict-items" changes that somehow seems to crash under tests (just to be safe, for now)

* Revert some of the "consider-using-dict-items" changes that somehow seems to crash under tests (just to be safe, for now)

* Remove some redundant conditions

* Update psutil

* Add CY2024 tests

* Remove dependency for PySide2 specifically in setup.py and rely on qtpy and requirements_gui.txt

* Fix check for search case sensitivity in log viewer

* Disable the LogViewerWidget._set_scrollbar_value since it's causing the search buttons to only search within visible text. Also it doesn't really seem to do anything.

* Fix logging to file, it shouldn't open the file since it's already open.

* Ignore non-ascii characters and don't add the extra newline.

* Disabled connecting the _set_scrollbar_value since it's causing the
search buttons to only search within visible text.
Also it doesn't really seem to do anything.
DiegoTavares added a commit to DiegoTavares/OpenCue that referenced this pull request Aug 28, 2024
Changes implemented by AcademySoftwareFoundation#1416 impacted the locking mechanism for handling permissions on rqd, causing multiple threads to compete for permission settings and access to passwd.

Besides fixing the bug, this PR also introduces a fix for a potential security issue that would allow frames to run as root if the frame user didn't exist and the process to create this user fails.
DiegoTavares added a commit that referenced this pull request Sep 6, 2024
Changes implemented by #1416 impacted the locking mechanism for handling
permissions on rqd, causing multiple threads to compete for permission
settings and access to passwords.

Besides fixing the bug, this PR also introduces a fix for a potential
security issue that would allow frames to run as root if the frame user
didn't exist and the process to create this user fails.
DiegoTavares added a commit that referenced this pull request Oct 2, 2024
Fix both the registry issues for images that rely on centos7 and the pip
package compatibility issues for python 3.6.

Some changes on PR #1416 didn't take into account that part of the
packaging pipeline relies on centos7, which doesn't support python3.7
without installing from source. On the next release, support to rhl7
might be dropped as we upgrade the pipeline to rely on rocky9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants