Add new indexes to improve booking performance #1304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After the changes on the gpu PR AcademySoftwareFoundation#924 the performance of the booking query degraded up to 4 times the previous throughput. Creating some indexes for columns that changed names seems to have fixed the problem. Signed-off-by: Diego Tavares <[email protected]>
DiegoTavares
requested review from
bcipriano,
gregdenton,
jrray,
smith1511,
larsbijl,
IdrisMiles and
splhack
as code owners
DiegoTavares
commented
Nov 8, 2023
cuebot/src/main/resources/conf/ddl/postgres/migrations/V18_Add_New_Indexes
Outdated
Show resolved
Hide resolved
cuebot/src/main/resources/conf/ddl/postgres/migrations/V18_Add_New_Indexes
Outdated
Show resolved
Hide resolved
…_New_Indexes Signed-off-by: Diego Tavares da Silva <[email protected]>
…_New_Indexes Signed-off-by: Diego Tavares da Silva <[email protected]>
DiegoTavares
commented
Nov 8, 2023
cuebot/src/main/resources/conf/ddl/postgres/migrations/V18_Add_New_Indexes
Outdated
Show resolved
Hide resolved
…_New_Indexes Signed-off-by: Diego Tavares da Silva <[email protected]>
|
@bcipriano Ready for review |
|
Ping |
bcipriano
approved these changes
Jan 30, 2024
| TABLESPACE pg_default; | ||
|
|
||
|
|
||
| create index concurrently i_layer_int_cores_max on layer(int_cores_max); |
There was a problem hiding this comment.
nit: use consistent capitalization within the file -- preferred CREATE INDEX CONCURRENTLY ... ON ...
DiegoTavares
merged commit 42542c1
into
AcademySoftwareFoundation:master
11 of 12 checks passed
carlosfelgarcia
pushed a commit
to carlosfelgarcia/OpenCue
that referenced
this pull request
May 22, 2024
…tion#1304) * Add new indexes to improve booking performance After the changes on the gpu PR AcademySoftwareFoundation#924 the performance of the booking query degraded up to 4 times the previous throughput. Creating some indexes for columns that changed names seems to have fixed the problem. Signed-off-by: Diego Tavares <[email protected]> * Update cuebot/src/main/resources/conf/ddl/postgres/migrations/V18_Add_New_Indexes Signed-off-by: Diego Tavares da Silva <[email protected]> * Update cuebot/src/main/resources/conf/ddl/postgres/migrations/V18_Add_New_Indexes Signed-off-by: Diego Tavares da Silva <[email protected]> * Update cuebot/src/main/resources/conf/ddl/postgres/migrations/V18_Add_New_Indexes Signed-off-by: Diego Tavares da Silva <[email protected]> --------- Signed-off-by: Diego Tavares <[email protected]> Signed-off-by: Diego Tavares da Silva <[email protected]>
carlosfelgarcia
pushed a commit
to carlosfelgarcia/OpenCue
that referenced
this pull request
May 22, 2024
…tion#1304) * Add new indexes to improve booking performance After the changes on the gpu PR AcademySoftwareFoundation#924 the performance of the booking query degraded up to 4 times the previous throughput. Creating some indexes for columns that changed names seems to have fixed the problem. Signed-off-by: Diego Tavares <[email protected]> * Update cuebot/src/main/resources/conf/ddl/postgres/migrations/V18_Add_New_Indexes Signed-off-by: Diego Tavares da Silva <[email protected]> * Update cuebot/src/main/resources/conf/ddl/postgres/migrations/V18_Add_New_Indexes Signed-off-by: Diego Tavares da Silva <[email protected]> * Update cuebot/src/main/resources/conf/ddl/postgres/migrations/V18_Add_New_Indexes Signed-off-by: Diego Tavares da Silva <[email protected]> --------- Signed-off-by: Diego Tavares <[email protected]> Signed-off-by: Diego Tavares da Silva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the changes on the gpu PR the performance of the booking query degraded up to 4 times the previous throughput. Creating some indexes for columns that changed names seems to have fixed the problem.