-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update blender version on sample Dockerfile #1259
Update blender version on sample Dockerfile #1259
Conversation
Update comments with version number Move directories
Remove version details from comment Add Blender install verification command
@bcipriano something I noticed and wanted to clarify before merging. |
@n-jay It's kind of a matter of preference. I don't think it's strictly necessary here, but you could use it if you want. If there are a lot of other Dockerfile instructions that need to run within that directory, it does help keep the Dockerfile simple. On the other hand, in a standard build-and-install process, if you set your An alternative in this case could be to use
This would reduce repetition, make it easy to change the directory in the future (you only have to update one line instead of several), and lets users override it with a custom value at build time via |
Noted, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM
Link the Issue(s) this Pull Request is related to.
PR related email thread linked here.
Summarize your change.
Updates the Blender version in sample Dockerfile to latest LTS release: v3.3
This change was made to complement the upcoming OpenCue Blender addon. Related discussion: #312