-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add layer max cores #1125
Add layer max cores #1125
Conversation
Previous PR was closed due to CLA issues. Regarding the comments, the minor version was changed in order to represent changes to proto. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No comments on the code.
Please add more context to the PR description mentioning the field already existed and is already part of the dispatchQuery, the only missing part is the ability to update it. While reviewing I was questioning if the newly added int_cores_max
was already part of the layer table because I don't see changes to the db schema.
|
Description updated. |
@bcipriano FYI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change LGTM, just one minor comment about the proto file, and please resolve that conflict with VERSION.in
(but make sure this PR still increments the minor version after the conflict is resolved).
6ba0446
to
f9a7200
Compare
f9a7200
to
afb599a
Compare
Link the Issue(s) this Pull Request is related to.
Currently, the
SET_ALL_RENDER_LAYER_CORES
filter action only affects the layer's min cores. This can be improved since in some cases setting only min cores or max cores is more beneficial.Summarize your change.
Changes
SET_ALL_RENDER_LAYER_CORES
toSET_ALL_RENDER_MIN_CORES
andSET_ALL_RENDER_MAX_CORES
which allows to set only max cores and/or min cores per layer.