Fix Group GPU APIs #1064
Merged
Fix Group GPU APIs #1064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
splhack
requested review from
bcipriano,
DiegoTavares,
gregdenton,
IdrisMiles,
jrray,
larsbijl and
smith1511
as code owners
splhack
force-pushed
the
cuebot-fix-group
branch
from
8e29fe1 to
12f77ee
Compare
DiegoTavares
approved these changes
Dec 1, 2021
bcipriano
approved these changes
Dec 4, 2021
splhack
force-pushed
the
cuebot-fix-group
branch
from
12f77ee to
cf50877
Compare
|
rebased onto master to fix CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Group GPU APIs should have not used CPU Cores check logic
(Those codes were copy-and-pasted in #924)
Also GROUP_DETAIL_MAPPER did not get min/max cores/gpus.