Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adsk Contrib - Remove the useless cmake target on oiiotool #1477

Merged
merged 5 commits into from
Sep 16, 2021

Conversation

hodoulp
Copy link
Member

@hodoulp hodoulp commented Sep 2, 2021

Signed-off-by: Patrick Hodoul [email protected]

The OpenImageIO oiiotool target is clearly useless to compile OpenColorIO, run the unit tests or use the apps.

@hodoulp
Copy link
Member Author

hodoulp commented Sep 8, 2021

The last commit improves the detection of the OpenImageIO_Util need. For version 2.2 or lower, the utility classes were declared in both libraries. Starting with the version 2.3, the utility classes are now only present in the OpenImageIO_Util library explaining the link breaks in OpenColorIO.

This improves the changes from the pull request #1478 which was merged to unlock other pull requests.

@hodoulp
Copy link
Member Author

hodoulp commented Sep 8, 2021

The PR is now a candidate for RB-2.1

@hodoulp
Copy link
Member Author

hodoulp commented Sep 15, 2021

Friendly reminder that the pull request could be merged this week so I will merge it this Friday.

@hodoulp hodoulp merged commit 9bc9711 into master Sep 16, 2021
@hodoulp hodoulp deleted the adsk_contrib/oiio_tool branch September 16, 2021 12:45
hodoulp added a commit that referenced this pull request Sep 16, 2021
* Adsk Contrib - REmove the useless cmake target on oiiotool

Signed-off-by: Patrick Hodoul <[email protected]>

* Improve the OIIO Util library support

Signed-off-by: hodoulp <[email protected]>
hodoulp added a commit that referenced this pull request Sep 25, 2021
…1494)

* Adsk Contrib - REmove the useless cmake target on oiiotool

Signed-off-by: Patrick Hodoul <[email protected]>

* Improve the OIIO Util library support

Signed-off-by: hodoulp <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants