-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adsk Contrib - Fix a CDL file load bug for ColorDecisionList case #1022
Merged
michdolan
merged 1 commit into
AcademySoftwareFoundation:master
from
autodesk-forks:adsk_contrib/cdl_fix
May 26, 2020
Merged
Adsk Contrib - Fix a CDL file load bug for ColorDecisionList case #1022
michdolan
merged 1 commit into
AcademySoftwareFoundation:master
from
autodesk-forks:adsk_contrib/cdl_fix
May 26, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick Hodoul <[email protected]>
@michdolan That's a very small review fixing a CDL bug and also unlocking Python unit tests. |
michdolan
approved these changes
May 26, 2020
meimchu
pushed a commit
to meimchu/OpenColorIO
that referenced
this pull request
Jun 1, 2020
…ademySoftwareFoundation#1022) Signed-off-by: Patrick Hodoul <[email protected]>
scoopxyz
pushed a commit
to scoopxyz/OpenColorIO
that referenced
this pull request
Jul 1, 2020
…ademySoftwareFoundation#1022) Signed-off-by: Patrick Hodoul <[email protected]>
scoopxyz
pushed a commit
to scoopxyz/OpenColorIO
that referenced
this pull request
Jul 12, 2020
…ademySoftwareFoundation#1022) Signed-off-by: Patrick Hodoul <[email protected]>
michdolan
pushed a commit
to michdolan/OpenColorIO
that referenced
this pull request
Jul 13, 2020
…ademySoftwareFoundation#1022) Signed-off-by: Patrick Hodoul <[email protected]>
amyspark
added a commit
to amyspark/OpenColorIO
that referenced
this pull request
Sep 20, 2021
This commit brings in the amalgamated header of the fast_float library, and applies it to our uses of sscanf with %f. This library is locale-free, and does not incur the performance penalty of using a thread locale RAII class. Fixes AcademySoftwareFoundation#297 Fixes AcademySoftwareFoundation#379 Fixes AcademySoftwareFoundation#1022
amyspark
added a commit
to amyspark/OpenColorIO
that referenced
this pull request
Sep 20, 2021
This commit brings in the amalgamated header of the fast_float library, and applies it to our uses of sscanf with %f. This library is locale-free, and does not incur the performance penalty of using a thread locale RAII class. Fixes AcademySoftwareFoundation#297 Fixes AcademySoftwareFoundation#379 Fixes AcademySoftwareFoundation#1022 Signed-off-by: L. E. Segovia <[email protected]>
amyspark
added a commit
to amyspark/OpenColorIO
that referenced
this pull request
Sep 20, 2021
This commit brings in the amalgamated header of the fast_float library, and applies it to our uses of sscanf with %f. This library is locale-free, and does not incur the performance penalty of using a thread locale RAII class. Fixes AcademySoftwareFoundation#297 Fixes AcademySoftwareFoundation#379 Fixes AcademySoftwareFoundation#1022 Signed-off-by: L. E. Segovia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Patrick Hodoul [email protected]
The pull request fixes a bug in the CDLTransform reader where files containing a
ColorDecisionList
were ignored.