Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adsk Contrib - Fix a CDL file load bug for ColorDecisionList case #1022

Conversation

hodoulp
Copy link
Member

@hodoulp hodoulp commented May 21, 2020

Signed-off-by: Patrick Hodoul [email protected]

The pull request fixes a bug in the CDLTransform reader where files containing a ColorDecisionList were ignored.

@hodoulp
Copy link
Member Author

hodoulp commented May 25, 2020

@michdolan That's a very small review fixing a CDL bug and also unlocking Python unit tests.

@michdolan michdolan merged commit d69dde5 into AcademySoftwareFoundation:master May 26, 2020
@hodoulp hodoulp deleted the adsk_contrib/cdl_fix branch May 26, 2020 11:45
meimchu pushed a commit to meimchu/OpenColorIO that referenced this pull request Jun 1, 2020
scoopxyz pushed a commit to scoopxyz/OpenColorIO that referenced this pull request Jul 1, 2020
scoopxyz pushed a commit to scoopxyz/OpenColorIO that referenced this pull request Jul 12, 2020
michdolan pushed a commit to michdolan/OpenColorIO that referenced this pull request Jul 13, 2020
amyspark added a commit to amyspark/OpenColorIO that referenced this pull request Sep 20, 2021
This commit brings in the amalgamated header of the fast_float library,
and applies it to our uses of sscanf with %f.

This library is locale-free, and does not incur the performance penalty of
using a thread locale RAII class.

Fixes AcademySoftwareFoundation#297
Fixes AcademySoftwareFoundation#379
Fixes AcademySoftwareFoundation#1022
amyspark added a commit to amyspark/OpenColorIO that referenced this pull request Sep 20, 2021
This commit brings in the amalgamated header of the fast_float library,
and applies it to our uses of sscanf with %f.

This library is locale-free, and does not incur the performance penalty of
using a thread locale RAII class.

Fixes AcademySoftwareFoundation#297
Fixes AcademySoftwareFoundation#379
Fixes AcademySoftwareFoundation#1022

Signed-off-by: L. E. Segovia <[email protected]>
amyspark added a commit to amyspark/OpenColorIO that referenced this pull request Sep 20, 2021
This commit brings in the amalgamated header of the fast_float library,
and applies it to our uses of sscanf with %f.

This library is locale-free, and does not incur the performance penalty of
using a thread locale RAII class.

Fixes AcademySoftwareFoundation#297
Fixes AcademySoftwareFoundation#379
Fixes AcademySoftwareFoundation#1022

Signed-off-by: L. E. Segovia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants