Fix problems with ImathInterval, and add test #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test for Imath::Interval was missing and it's not included anywhere else in the library, so builds were not compiling it and thus not catching syntax errors. These changes also bring it more in line with the Box<T> class. * misspelling of "constexpr" * replace constexpr with IMATH_CONSTEXPR14 * add makeInfinite()/isInfinite() for similarity with Box<T> * add operator<< * add ImathTest/testInterval.cpp, based on testBox.cpp Signed-off-by: Cary Phillips <[email protected]>
lgritz
approved these changes
Sep 3, 2020
|
One other change here: Imath::Interval::size() now returns 0 if the interval is empty (consistent with Box). The existing code returns max-min, which for an empty Interval (via makeEmpty()) would overflow, since max=-limits::min() and min=limits::max(). This breaks compatibility, but the existing behavior sure seems like a bug. |
|
I agree, I think you're justified in saying that this is a bug fix, not a change in any useful or expected behavior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test for Imath::Interval was missing and it's not included
anywhere else in the library, so builds were not compiling it and thus
not catching syntax errors. These changes also bring it more in line
with the Box class.
Signed-off-by: Cary Phillips [email protected]