Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump required cmake to 3.14 #373

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

cary-ilm
Copy link
Member

This should have gone into PR #366, since file(CREATE_LINK) was introduced in cmake 3.14, not sure how it slipped through the CI.

This should have gone into PR AcademySoftwareFoundation#366, since `file(CREATE_LINK)` was
introduced in cmake 3.14, not sure how it slipped through the CI.

Signed-off-by: Cary Phillips <[email protected]>
@lgritz
Copy link
Contributor

lgritz commented Feb 22, 2024

I'm fine with this for main. In fact, if we're going to bump cmake, I would recommend going to 3.15 -- among other things, the new-to-3.15 -B and -S arguments make for much simpler instructions when explaining how to build the project to people unfamiliar with cmake (no more "mkdir build ; cd build ; cmake .." dance).

But I think we should be very careful about backporting this to released branches. Most projects try to avoid changing minimal build dependency requirements for existing release families.

@kmilos
Copy link

kmilos commented Feb 22, 2024

But I think we should be very careful about backporting this to released branches. Most projects try to avoid changing minimal build dependency requirements for existing release families.

True, but at the same time, this is kinda low risk as already satisfied on all distros shipping Imath 3.1.x (or still in LTS, like Ubuntu 20.04, so can make it 3.16 even):

https://repology.org/project/imath/versions
https://repology.org/project/cmake/versions

@cary-ilm
Copy link
Member Author

I'm not sure what to do regarding a v3.1.11 release. The risk seems low, since it's likely that anyone restricted to a pre-3.14 CMake won't adopt a new release of Imath, but possibly that's not a good assumption.

The next minor release of Imath might be quite a while, I'd prefer to move forward, but if that's bad policy, I'm fine being conservative and not release this in a patch.

@cary-ilm
Copy link
Member Author

I decided to wait for the next minor release for this, so it's not going into 3.1.11.

And I'll submit another bump to 3.15 that also updates the documentation in reference to -S and -B.

@cary-ilm cary-ilm merged commit 195b477 into AcademySoftwareFoundation:main Feb 29, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants