Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix memory leak in V3fArrayFromBuffer #269

Merged
merged 1 commit into from
Oct 13, 2022
Merged

fix memory leak in V3fArrayFromBuffer #269

merged 1 commit into from
Oct 13, 2022

Conversation

cary-ilm
Copy link
Member

Courtesy of @cbreak-black, #266

https://docs.python.org/3/c-api/buffer.html#c.PyBuffer_Release
https://docs.python.org/3/c-api/arg.html

However, when a Py_buffer structure gets filled, the underlying buffer is locked so that the caller can subsequently use the buffer even inside a Py_BEGIN_ALLOW_THREADS block without the risk of mutable data being resized or destroyed. As a result, you have to call PyBuffer_Release() after you have finished processing the data (or in any early abort case).

Signed-off-by: Cary Phillips [email protected]

@meshula meshula merged commit 7206ad1 into AcademySoftwareFoundation:main Oct 13, 2022
cary-ilm added a commit to cary-ilm/Imath that referenced this pull request Oct 31, 2022
@cary-ilm
fix memory leak in V3fArrayFromBuffer (AcademySoftwareFoundation#269)
151083b
@cary-ilm cary-ilm mentioned this pull request Oct 31, 2022
Merged
cary-ilm added a commit that referenced this pull request Nov 3, 2022
@cary-ilm
fix memory leak in V3fArrayFromBuffer (#269)
b07be04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meshula meshula meshula approved these changes

Assignees
No one assigned
Labels
v3.1.6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cary-ilm @meshula