commits and notes for v3.1.5 release #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion#236) Signed-off-by: Cary Phillips <[email protected]>
…eFoundation#241) Previously, these specializations have been in the header halfLimit.h, but without this header, the numeric_limits<> template provides default specializations that return 0, so, for example, std::numeric_limits<half>::min() would silently return 0 in code that inadvertently omitted the #include <halfLimits.h>. The numeric_limits specializations should be considered an inseparable part of the class definition. This change moves the specializations directly into half.h and deprecates the halfLimits.h header altogether. For backwards compatibility, it includes half.h with a warning. An alternative would be to keep halfLimits.h and include it in half.h, but then each header would include the other circularly, which is awkward. Signed-off-by: Cary Phillips <[email protected]>
…undation#244) Add: #if defined(__F16C__) # include <immintrin.h> to the logic in half.h for including intrinsics header, which catches the i386 case. Signed-off-by: Cary Phillips <[email protected]>
…ndation#245) * Use _WIN32 instead of _MSC_VER to fix mingw build Signed-off-by: Cary Phillips <[email protected]> * fix formatting Signed-off-by: Cary Phillips <[email protected]>
Signed-off-by: Christina Tempelaar-Lietz <[email protected]>
Signed-off-by: Cary Phillips <[email protected]>
Signed-off-by: Cary Phillips <[email protected]>
meshula
approved these changes
Mar 22, 2022
Signed-off-by: Cary Phillips <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch release with miscellaneous bug/doc/build fixes.
In particular, this fixes an issue that could lead to incorrect values for numeric_limits. This also updates the CI workflow matrix to VFX-CY2022.
[#245] Use _WIN32 instead of _MSC_VER to fix mingw build
[#244] Fix 32-bit x86 build failure with 16c instructions
[#241] Move numeric_limits specializations into half.h
[#236] Change references to "master" branch to "main"