Add docs target only if not a subproject #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Imath is a subproject (as with OpenEXR), the "docs" target can conflict with the parent project's "docs" target. And the Imath docs shouldn't be built by the parent project, anyway. Signed-off-by: Cary Phillips <[email protected]>
|
What happens in the case that Imath is automagically installed by OpenEXR itself? I think in that case Imath is not a subproject, and so,, should the build docs option be overridden by the settings of OpenEXR? Am I overthinking it? ;) |
|
I'm pretty sure that when OpenEXR fetches Imath, IMATH_IS_SUBPROJECT is true. I did a test to confirm, and assuming I tested the right thing, it works. |
meshula
approved these changes
Oct 29, 2021
cary-ilm
added a commit
to cary-ilm/Imath
that referenced
this pull request
Jan 17, 2022
When Imath is a subproject (as with OpenEXR), the "docs" target can conflict with the parent project's "docs" target. And the Imath docs shouldn't be built by the parent project, anyway. Signed-off-by: Cary Phillips <[email protected]>
cary-ilm
added a commit
that referenced
this pull request
Jan 20, 2022
When Imath is a subproject (as with OpenEXR), the "docs" target can conflict with the parent project's "docs" target. And the Imath docs shouldn't be built by the parent project, anyway. Signed-off-by: Cary Phillips <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Imath is a subproject (as with OpenEXR), the "docs" target can
conflict with the parent project's "docs" target. And the Imath docs
shouldn't be built by the parent project, anyway.
Signed-off-by: Cary Phillips [email protected]