Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick commits for v3.1.3, plus notes and version bump #205

Merged

Conversation

cary-ilm
Copy link
Member

Library version goes from 29.1.0 to 29.2.0 because:

  • Source code has changed (bug fixes)
  • Headers changed but only in ways that should not affect the API:
  • The CUDA fixes are invisible to non-CUDA compilers
  • The _has_attribute should only affect compilers where the build was previously completely failing.

PR's:

  • [#204] Fix undefined access of a vector when empty
  • [#203] Require sphinx 4.0.3
  • [#201] Build sphinx/doxygen docs with CMake
  • [#200] Use PYIMATH_OVERRIDE_PYTHON_INSTALL_DIR to specify destination python modules
  • [#199] Guard __has_attribute for compilers that don't support it
  • [#198] Cuda safety fixes
  • [#194] Replace stray Imath:: with IMATH_INTERNAL_NAMESPACE::

cary-ilm and others added 8 commits August 30, 2021 10:02
…oftwareFoundation#199)

* Guard `__has_attribute` for compilers that don't support it

Signed-off-by: Larry Gritz <[email protected]>

* take 2

Signed-off-by: Larry Gritz <[email protected]>
… modules (AcademySoftwareFoundation#200)

The previous PYIMATH_OVERRIDE_PYTHON2_INSTALL_DIR and
PYIMATH_OVERRIDE_PYTHON3_INSTALL_DIR options were left over from when
python2 and python3 could be built simultaneously, and even worse,
they were ignored. There's no need for two variables now. This takes
effect only if it is provided.

Also, INSTALL.md properly mentions PYTHON, USE_PYTHON2, and
PYIMATH_OVERRIDE_PYTHON_INSTALL_DIR.

Signed-off-by: Cary Phillips <[email protected]>
There seems to be a bug in newer versions of Sphinx that cause the
readthedocs build to fail, reported here:
sphinx-doc/sphinx#9584.

Until that is resolved, this avoids it.

Signed-off-by: Cary Phillips <[email protected]>
* Build sphinx/doxygen docs with CMake

* The DOCS CMake option runs doxygen and sphinx to build the html
  documentation. Default if OFF. If ON, it requires doxygen and sphinx
  to be installed (found via FindSphinx.cmake).

* Describe the documentation generation option in INSTALL.md.

* Fix broken references in half.rst.

* Remove quotes around some template function names in doxygen
  comments that result in unresolved references.

Signed-off-by: Cary Phillips <[email protected]>

* Add copyright/license

Signed-off-by: Cary Phillips <[email protected]>

* Fix dependencies

Signed-off-by: Cary Phillips <[email protected]>

* Restore conf.py for RTD

Signed-off-by: Cary Phillips <[email protected]>

* Fix typo in conf.py for RTD

Signed-off-by: Cary Phillips <[email protected]>

* typo

Signed-off-by: Cary Phillips <[email protected]>

* Fix merge

Signed-off-by: Cary Phillips <[email protected]>

* Remove Doxyfile

Signed-off-by: Cary Phillips <[email protected]>
Signed-off-by: Cary Phillips <[email protected]>
Library version goes from 29.1.0 to 29.2.0 because:
* Source code has changed (bug fixes)
* Headers changed but only in ways that should not affect the API:
  * The CUDA fixes are invisible to non-CUDA compilers
  * The _has_attribute should only affect compilers where the build
    was previously completely failing.

Signed-off-by: Cary Phillips <[email protected]>
Copy link
Contributor

@meshula meshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@cary-ilm cary-ilm merged commit 6dc0820 into AcademySoftwareFoundation:RB-3.1 Sep 1, 2021
@cary-ilm cary-ilm added the v3.1.3 label Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants