-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherry-pick commits for v3.1.3, plus notes and version bump #205
Merged
cary-ilm
merged 8 commits into
AcademySoftwareFoundation:RB-3.1
from
cary-ilm:v3.1.3-cherry-picks
Sep 1, 2021
Merged
Cherry-pick commits for v3.1.3, plus notes and version bump #205
cary-ilm
merged 8 commits into
AcademySoftwareFoundation:RB-3.1
from
cary-ilm:v3.1.3-cherry-picks
Sep 1, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eFoundation#194) Signed-off-by: Cary Phillips <[email protected]>
…oftwareFoundation#199) * Guard `__has_attribute` for compilers that don't support it Signed-off-by: Larry Gritz <[email protected]> * take 2 Signed-off-by: Larry Gritz <[email protected]>
… modules (AcademySoftwareFoundation#200) The previous PYIMATH_OVERRIDE_PYTHON2_INSTALL_DIR and PYIMATH_OVERRIDE_PYTHON3_INSTALL_DIR options were left over from when python2 and python3 could be built simultaneously, and even worse, they were ignored. There's no need for two variables now. This takes effect only if it is provided. Also, INSTALL.md properly mentions PYTHON, USE_PYTHON2, and PYIMATH_OVERRIDE_PYTHON_INSTALL_DIR. Signed-off-by: Cary Phillips <[email protected]>
There seems to be a bug in newer versions of Sphinx that cause the readthedocs build to fail, reported here: sphinx-doc/sphinx#9584. Until that is resolved, this avoids it. Signed-off-by: Cary Phillips <[email protected]>
…n#204) Signed-off-by: Kimball Thurston <[email protected]>
* Build sphinx/doxygen docs with CMake * The DOCS CMake option runs doxygen and sphinx to build the html documentation. Default if OFF. If ON, it requires doxygen and sphinx to be installed (found via FindSphinx.cmake). * Describe the documentation generation option in INSTALL.md. * Fix broken references in half.rst. * Remove quotes around some template function names in doxygen comments that result in unresolved references. Signed-off-by: Cary Phillips <[email protected]> * Add copyright/license Signed-off-by: Cary Phillips <[email protected]> * Fix dependencies Signed-off-by: Cary Phillips <[email protected]> * Restore conf.py for RTD Signed-off-by: Cary Phillips <[email protected]> * Fix typo in conf.py for RTD Signed-off-by: Cary Phillips <[email protected]> * typo Signed-off-by: Cary Phillips <[email protected]> * Fix merge Signed-off-by: Cary Phillips <[email protected]> * Remove Doxyfile Signed-off-by: Cary Phillips <[email protected]>
Signed-off-by: Cary Phillips <[email protected]>
Library version goes from 29.1.0 to 29.2.0 because: * Source code has changed (bug fixes) * Headers changed but only in ways that should not affect the API: * The CUDA fixes are invisible to non-CUDA compilers * The _has_attribute should only affect compilers where the build was previously completely failing. Signed-off-by: Cary Phillips <[email protected]>
meshula
approved these changes
Aug 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Library version goes from 29.1.0 to 29.2.0 because:
PR's:
__has_attribute
for compilers that don't support it