Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure ImathTest as optional standalone program #153

Merged
merged 5 commits into from
Jun 1, 2021

Conversation

cary-ilm
Copy link
Member

  • src/ImathTest/CMakeLists.txt invokes project()/find_package() when
    invoked from the top level, making it possible to configure the
    tests as a standalone program linking against an externally-built
    Imath library.

  • Fix #include statements in ImathTest so Imath headers are included
    with <> and local headers are included with "".

  • The CI now has a step to configure and build ImathTest as a
    standalone program, and to validate that the python module is
    loadable.

  • This also cleans out some unnecessary lines from the CI file that date from
    before the change to building only a single python version at a time.

Signed-off-by: Cary Phillips [email protected]

cary-ilm added 2 commits May 29, 2021 17:18
* src/ImathTest/CMakeLists.txt invokes project()/find_package() when
  invoked from the top level, making it possible to configure the
  tests as a standalone program linking against an externally-built
  Imath library.

* Fix #include statements in ImathTest so Imath headers are included
  with <> and local headers are included with "".

* The CI now has a step to configure and build ImathTest as a
  standalone program, and to validate that the python module is
  loadable.

Signed-off-by: Cary Phillips <[email protected]>
Signed-off-by: Cary Phillips <[email protected]>
Copy link
Contributor

@meshula meshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a nice cleanup.

@cary-ilm cary-ilm merged commit 8466a39 into AcademySoftwareFoundation:master Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants