#if IMATH_FOREIGN_VECTOR_INTEROP around type detectors #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Vec/Matrix interoperability constructors are already #if'd out for older compilers. This #if's out the template definitions themselves, which can cause errors aside from the constructors. Signed-off-by: Cary Phillips <[email protected]>
|
It passed CI. What compilers was this failing for? |
|
CUDA 10.1. There may be something wonky about my installation of nvcc,
because even passing in gcc6.3.1 generates errors with the templates. But
the templates don’t have a use outside of the interop constructors, so it
seems safe to exclude them similarly.
|
lgritz
approved these changes
Mar 25, 2021
cary-ilm
added a commit
that referenced
this pull request
Mar 25, 2021
The Vec/Matrix interoperability constructors are already #if'd out for older compilers. This #if's out the template definitions themselves, which can cause errors aside from the constructors. Signed-off-by: Cary Phillips <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Vec/Matrix interoperability constructors are already #if'd out for
older compilers. This #if's out the detector template definitions themselves,
which can cause errors with older compilers aside from the constructors.
Signed-off-by: Cary Phillips [email protected]