build one python binding only

[waebbl]

I tried to look into that. The patch worked for me with python-3, but unfortunately I couldn't test with python-2.
Feel free to review and address any changes needed, if you want to consider the patch.

Bug: #108
Signed-off-by: Bernd Waibel [email protected]

[meshula]

This looks good to me. Would be good to get a second reviewer.

[cary-ilm]

Thank you for this! I tried it out and it seems to work just as expected. I'm glad to have this in place, it simplifies matters.

Wouldn't it be better for the option to be USE_PYTHON2 and default to off, rather than USE_PYTHON3 and default to on? That way, saying nothing about python version would do the right modern thing, and when we drop support for python2, it's just a matter of removing the option altogether.

[waebbl]

Wouldn't it be better for the option to be USE_PYTHON2 and default to off, rather than USE_PYTHON3 and default to on? That way, saying nothing about python version would do the right modern thing, and when we drop support for python2, it's just a matter of removing the option altogether.

I'm open for both ways.
Though I wonder if it makes a difference at all?

• Current way: py3 default to ON, so saying nothing will do the modern thing, if py2 is dropped, only -DPYTHON is needed and it can be dropped.
• Alternative way: py2 default to OFF, saying nothing will do the modern thing, if py2 is dropped, only -DPYTHON is needed and it can be dropped.

Or do I miss something?

[cary-ilm]

Functionally the two are equivalent, so it's a minor nitpick, but I think it makes more sense if backwards-compatibility options default to off, so their absence leads to the right efault behavior.

…

On Mon, Mar 8, 2021 at 9:05 AM Bernd ***@***.***> wrote: Wouldn't it be better for the option to be USE_PYTHON2 and default to off, rather than USE_PYTHON3 and default to on? That way, saying nothing about python version would do the right modern thing, and when we drop support for python2, it's just a matter of removing the option altogether. I'm open for both ways. Though I wonder if it makes a difference at all? - Current way: py3 default to ON, so saying nothing will do the modern thing, if py2 is dropped, only -DPYTHON is needed and it can be dropped. - Alternative way: py2 default to OFF, saying nothing will do the modern thing, if py2 is dropped, only -DPYTHON is needed and it can be dropped. Or do I miss something? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#109 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFC3DGLCS5MXYTVMZWJ2SY3TCT7V7ANCNFSM4YV4ZZ6Q> .

-- Cary Phillips | R&D Supervisor | ILM | San Francisco

[waebbl]

I understand. Gonna change it to USE_PYTHON2 then.

[cary-ilm]

I downloaded this and tried it out on both linux and macOS systems that have both python2 and python3 and it seems to work as expected. Can someone also confirm this does the right thing on Windows?

If you can delete the commented-out lines, we should be good to go. Thanks!

[waebbl]

Thanks for testing this on alternate platforms and python2.
I removed the comments and just noticed I have to pull changes first, so there'll be another push soon.