Fit screen full screen fix #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The `swapChainTexture` is too big to copy to `texture2d.texture` when the screen size changes, that be fit window or full screen, so the texture size is updated just on those instances of a resize call instead of updating it on every frame on `update` that caused the app to slow down if I had taken that route.
- The fitWindow call is not consistent when you switch a demo, this because the size is set as the current canvas, then it makes no sense to remove the fitWindow if the canvas size is now a new one, so restoring the value to 800x800 default size enforces that. - Then we don't save the boolean in localstorage and we force its value to false in datgui for the check to go back to unchecked state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves #110 and other minor changes related