Allow cw-orch wasm compilation without features #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
17e108f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0c8feadd.cw-orchestrator.pages.dev |
| Branch Preview URL: | https://misha-orc-85-cw-orchqueryfns.cw-orchestrator.pages.dev |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
|
Buckram123
commented
Mar 13, 2024
CyberHoward
reviewed
Mar 14, 2024
| #[cfg(feature = "daemon")] | ||
| pub mod daemon; | ||
|
|
||
| #[cfg(not(target_arch = "wasm32"))] | ||
| mod error; | ||
| #[cfg(feature = "osmosis-test-tube")] | ||
| pub mod osmosis_test_tube; |
There was a problem hiding this comment.
We should either arch-flag all the exports or only the non-featured ones (if we assume a user doesn't enable the feature in their wasm env).
Right now daemon is arch-flagged but test-tube is not.
There was a problem hiding this comment.
I think arch-flagging features would work as well!
There was a problem hiding this comment.
Oups, that's a mistake yes
There was a problem hiding this comment.
flaggin features doesn't seem to work : rust-lang/cargo#1197
Kayanski
deleted the
misha/orc-85-cw_orchqueryfnsexecutefns-attributes-fails-to-expand-with
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to allow adding derive attributes for wasm targets, by not generating any code.
Interface can be removed as well.
Users can also use the
#[cfg(not(target_arch = "wasm32"))]to shield the interface instead of the interface feature