Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to query version of no-cw2 modules #69

Conversation

Buckram123
Copy link
Collaborator

@Buckram123 Buckram123 commented Sep 11, 2023

To accomplish querying of no-cw2 modules infos we have two few options

  1. Return None for contract version
  2. Return abstract-core type ModuleVersion of installed module, in case cw2 query failed

This PR implements second option.

Left to discuss:

  • Right now it will try to return ModuleVersion of any no-cw2 contract, we can make it returning ModuleVersion for every Standalone, since they will have non-abstract format for cw2 or no-cw2 at all

Checklist

  • CI is green.
  • Changelog updated.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Sep 11, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: a5802e3
Status: ✅  Deploy successful!
Preview URL: https://aa598e35.abstract-docs.pages.dev
Branch Preview URL: https://misha-abs-182-querying-manag.abstract-docs.pages.dev

View logs

@Buckram123 Buckram123 changed the title Add ability to query no-cw2 modules Add ability to query version of no-cw2 modules Sep 11, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2023

Codecov Report

Merging #69 (2250940) into main (7c9c262) will increase coverage by 18.42%.
Report is 120 commits behind head on main.
The diff coverage is 43.10%.

❗ Current head 2250940 differs from pull request most recent head a2eec83. Consider uploading reports for the commit a2eec83 to get more accurate results

@@             Coverage Diff             @@
##             main      #69       +/-   ##
===========================================
+ Coverage   24.28%   42.70%   +18.42%     
===========================================
  Files         266      225       -41     
  Lines       23391    16779     -6612     
===========================================
+ Hits         5680     7166     +1486     
+ Misses      17711     9613     -8098     
Files Changed Coverage Δ
framework/contracts/account/manager/src/error.rs 0.00% <ø> (ø)
framework/contracts/account/proxy/src/contract.rs 60.78% <ø> (+19.60%) ⬆️
framework/contracts/account/proxy/src/queries.rs 44.59% <ø> (+44.59%) ⬆️
...work/contracts/native/account-factory/src/error.rs 0.00% <ø> (ø)
...rk/contracts/native/account-factory/src/queries.rs 0.00% <0.00%> (ø)
...ramework/contracts/native/ans-host/src/commands.rs 63.80% <0.00%> (+0.60%) ⬆️
framework/contracts/native/ans-host/src/queries.rs 3.98% <ø> (ø)
...k/contracts/native/version-control/src/contract.rs 47.31% <0.00%> (+0.99%) ⬆️
...work/contracts/native/version-control/src/error.rs 25.00% <ø> (ø)
...packages/abstract-adapter/src/endpoints/execute.rs 55.92% <ø> (ø)
... and 67 more

... and 115 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@CyberHoward CyberHoward merged commit 6595c5e into main Sep 13, 2023
11 checks passed
@CyberHoward CyberHoward deleted the misha/abs-182-querying-managers-module_versionmodule_infos-of-standalone branch September 13, 2023 14:06
CyberHoward added a commit that referenced this pull request Sep 18, 2023
36293833 bump version to 0.17.0-rc0
88ad6dd4 rebuild with d72fe81
600c6b76 bump version to 0.16.2
aa250720 add cl and cosmwasmpool serialization
16cc259b Update latest osmosis tag timestamp to 1692139765
5997b879 Update latest osmosis tag timestamp to 1690829544
c99bf5b8 bump version to v0.16.1
0fa82db4 Merge pull request #82 from apollodao/dev/stderror-constructors
def6418b fix: Use StdError constructor functions
886f137c Update latest osmosis tag timestamp to 1689430935
f686934e Update latest osmosis tag timestamp to 1689204543
ea472044 update version to 0.16.0
b1d716f7 rebuild with 3b157de
56c3ddab Update latest osmosis tag timestamp to 1688675353
fa9b4c6e Update latest osmosis tag timestamp to 1688662108
7408b69f Update latest osmosis tag timestamp to 1688564605
b78e29b7 Update latest osmosis tag timestamp to 1688353566
2f196176 add to_proto_bytes and to_any to CosmWasmExt
2a57dad0 gen feegrant types
a6431f75 Update latest osmosis tag timestamp to 1687920590
268a7957 update version
202bf023 v0.16.0-beta.0
af36f5e0 Merge pull request #80 from apollodao/dev/backtraces
9682deeb fix: Only use osmosis-test-tube as dev dependency
853d8bd7 feat: generate types for gov module
269ba487 feat: Add backtraces feature to osmosis-std-derive
5c109e61 chore: bump test-tube version in tests
adc60f00 rebuild with be63fb5
529f8a6d change latest osmosis version to v16
6bc6365e fix outdate code gen
2b31b138 fix unused and deprecation warnings
370ddcf8 rebuild with 91e6167
d6608062 Update latest osmosis tag timestamp to 1685030419
be80543f Merge pull request #77 from apollodao/dev/cosmwasm-types
9bb297a0 Merge pull request #6 from osmosis-labs/main
36170cce fix: Fix repeated names in type url
a139d47b Update latest osmosis tag timestamp to 1682958492
b0860d06 Update latest osmosis tag timestamp to 1682524082
f726d5f5 Update latest osmosis tag timestamp to 1682002311
e3043a8f Update latest osmosis tag timestamp to 1681930256
6447b509 update main with new generator logic
b49394b3 bump version to 0.15.2
fc082323 rebuild with b01fd3e
4a5ca9a5 add alias generation for all _id fields
3d53e6af rebuild with 087a97b
895526d6 bump version and add main back
61b0879a update v0.15.1
d6bfba38 Remove osmosis testing
421a509a Merge pull request #78 from osmosis-labs/coins-conversion
cae052d4 add utils for converting cosmwasm coins/osmosis std coins
7616cb61 feat: Generate types for cosmwasm
765f3910 rebuild with a55bbb9
6841a23f rebuild with 3ffb10f
c9394477 rebuild with 3ffb10f
9e3ee07a Merge pull request #72 from larry0x/bump-to-latest
355861fb remove private imports
a6f3e521 Update latest osmosis tag timestamp to 1678471069
19873fe3 Merge pull request #71 from osmosis-labs/buf-replacement
de0617ed remove osmosis-testing updates
b95c82c7 add proper name to generate code step
8d6f6fb9 install buf on github action
8d65c6a3 use buf to perform generation instead of pure prost
0aeaafef Update latest osmosis tag timestamp to 1678220834
681a6d09 Update latest osmosis tag timestamp to 1678137645
bda281b3 Merge pull request #69 from osmosis-labs/additional-field-tests
1b71d4ea add additional field test
5a7d651a Update latest osmosis tag timestamp to 1677874810
09077b68 Update latest osmosis tag timestamp to 1677686162
aa044b3e Update latest osmosis tag timestamp to 1677626706
4a76e198 Update latest osmosis tag timestamp to 1677246806
14be9fbe Merge pull request #67 from osmosis-labs/authz
e3c402b8 add alias ID and exclude abci
63e5468b Update latest osmosis tag timestamp to 1676918026
e55c3aea Update latest osmosis tag timestamp to 1676473083
504c5064 Merge pull request #66 from omahs/patch-1
2cdb18f2 Fix: typos
b83ccc8c Fix: typo
2e9ee092 Fix: typos
0631b2b7 Fix: typos
bbbbb633 Fix: typos
1b672257 Fix: typos
73a92b18 Update latest osmosis tag timestamp to 1675945037
b96cc52a alias id
6ce540bd update with new lockup params
718577d4 alias PertiodLock ID
5b2705d1 update osmosis versionc
5d8891ee add ID alias
3aae7998 Update latest osmosis tag timestamp to 1673971085
72b27d77 add mod authz
23fde0eb add authz
5510df08 Update latest osmosis tag timestamp to 1673367355
d24284c1 Update latest osmosis tag timestamp to 1673513119
730c9f0e Update latest osmosis tag timestamp to 1673450503
902ff9a4 Update README.md
ff71e58a Update latest osmosis tag timestamp to 1673367355
6d89b604 Update latest osmosis tag timestamp to 1673105747
abd689d2 rebuild with 1c6c3c0
5f2493aa go get from libosmosistesting
ed138dea make geometric twap works
23bd4381 rebuild with 1c6c3c0
6ada002e Update latest osmosis tag timestamp to 1672706303
de390638 older lastest tag
2ac211b8 add origin main
4cc6c938 Update latest osmosis tag timestamp to 1672706303
c1524f38 remove exit
24b0631d older timestamp
0e8c77f3 Update latest osmosis tag timestamp to 1672715714
1e81669f >= latest
0704d8e5 no strip origin
2ea8a7fa Update latest osmosis tag timestamp to 1672706303
45260635 fitler only 13++ or main
7dfa5369 Update latest osmosis tag timestamp to 1672706303
60212d6a make latest osmosis tag older
f49dad65 Update latest osmosis tag timestamp to 1672715714
9a9e1f7b Update latest osmosis tag timestamp to 1672706303
7654b3d1 update script
bf9c31f6 Update latest osmosis tag timestamp to 1672706303
df9148ae trick update timestamp
74dd491b remove latest tag timestamp to reset workflow
a4362ab3 fix yaml
c088f636 update gh action go version to 1.19
b5daf06a Update latest osmosis tag timestamp to 1672706303
17cb0a4f getting the right version
9de55eff rebuild with 1c6c3c0
e3de1167 rebuild with 1c6c3c0
c49a0dc7 update rebuild osmosis testing
08c60419 Update latest osmosis tag timestamp to 1672566788
d012f4aa Update latest osmosis tag timestamp to 1671818502
454e48d7 Update latest osmosis tag timestamp to 1671721476
dd9a9143 Update latest osmosis tag timestamp to 1671655935
3c8c03d2 Update latest osmosis tag timestamp to 1671225434
18037e9b Update README.md according to #40
68708f2c Merge pull request #64 from osmosis-labs/endblock-on-error
65ae368a ensure endblock is being called even when execution fail
353bb09a Merge pull request #63 from osmosis-labs/autobuild-main
6188054d rebuild with 4176b28
6540d2a0 Update README.md
97c5724f [workflow] check diff before trying to commit
cc40037c [workflow] cd back to root before commit
188450f0 [workflow] init submodule
1594ae74 [workflow] checkout before run
08e2c2f6 [workflow] checks for new stuffs after latest tag
28706260 [workflow] update from deprecated set-output
b18b06b0 [workflow] fix output scope
6d1b34f1 [workflow] test dynamic matrix
22442402 change cron from 5mins to 1 hr
15cae9e1 fix
4465b923 fix
75b460df follow doc
7cd204b8 check
357fd047 specific for main build
13420ce3 try check using submodule
1a2502ad fix
4537949f clone via shell
b54797b6 fix2
5a6f0810 fix
3753963d [workflow] add fix
6f9c0fb1 [workflow] check updates
f925bd81 [workflow] rename and add workflow call
6b34be06 [workdlow][debug] add git config for bot
2809fcb0 [workdlow][debug] sed -i
8f8b8aa4 [workdlow][debug] diff
596aa7ad [workdlow][debug] remove cat
e3348789 [workdlow][debug] ignore sigint on tee
f36896a8 [workdlow][debug] cat main.rs
e3efadd7 rebuild with 4176b28
dff64136 update script to be more robust
02d4ea44 rebuild with 28234a5
abe3c8ac rebuild with 7568297
6c217d93 [workflow] setup cargo cache
3c17a1e7 [workflow] remove ls
b8789e0a checkout before run
0bba18ae run proto build on workflow
59c7b595 make version choice
56401958 update workflows
9d7a7117 test gh workflow
52b564b7 bump to v0.13.2
52212735 update deps
41a77781 fix wrong NulError report
1917ebbd Merge pull request #62 from osmosis-labs/osmosis-v13
819a8cc2 update to v13.1.1
fb79d488 update to osmosis v13.0.0-rc5
d2f5e09f twap example
660ba88d update deps to osmosis v13.0.0-rc4
b8bb07cb use transformer parse and append  option as macro
5f6fe6fd add deprecation to specific struct & fns
b3df8515 Cosmos Bank Types (#56)
483f110d refactor
8808b405 chore - update versions used for proto gen
33c9677a chore - remove relative path
ca543151 chore - review
cc0a4497 gen types for v13
8211146b chore - gen latest types
f1608760 chore - cleanup
f73b5198 feat - generate cosmos bank types
3ea06eda feat: rebuild types
9b010acf Merge pull request #55 from osmosis-labs/feat/derive-eq
0e170c37 [prost-build] derive Eq if PartialEq exist
a4274ac1 feat: run proto-build over latest version of osmosis
28ffd12e Merge branch 'feat/msg-force-unlock-type'
3976a1c6 proto-build osmosis@1e80a2a220911cbd776f68e8fa5655870a5f5d98
4d57a464 feat: add MsgForceUnlock to osmosis types
717b8ef6 add submessage result conversion to CosmwasmExt
cc9f25c3 add more fns to tokenfactory & bank
7f3e4db8 make From<#ident> for CosmosMsg more generic
4e1339fa Update README.md
7548436e update readme
cdd52902 bump version to v0.12.0
b9577fe2 update osmosis-testing to osmosisv12
599a0230 Merge pull request #44 from osmosis-labs/boss/fix-json-deser
3142a24d clippy
0c7f55a2 update types to match v12
f0cd43b7 improve the hack explanation
605556e7 fix any type problem
22f49a6b clippy fix
a3f91143 fix any issue
95c18682 fix duration deser
c28b5f5e fix timestamp response
380de671 use path join instead of string join
17ff0a26 add contract for testing serde with chain's logic
a7c73b2a refactor and fix lint
5623a1ba coerce privitive types from json string
9dff36c3 bump osmosis-testing to v0.1.8
90fabacf fix doc build
d042b8fc Update documentation for osmosis-testing
9857b329 update each package's readme with new desc
98d370ba fix security alert
684fa2b7 add readme to osmosis-std-derive and osmosis-testing
b32f9cb9 fix wrong rebuild detection
8408767c update osmosis deps
27e2065b update osmosis-std link
28c5a8c4 make osmosis-std doc test pass
c77d30f9 add badges to osmosis-std
6cda7b11 update description on readme.md
5531fe52 write bindings to out dir instead of src
3e584134 enable wasm debug api
ca1e6164 bump version to 0.1.7
e227ae58 update deps version to support cosmwasm 1.1
e0141b8f update osmosis to v12.0.0-rc2
e0b880b1 add metadata
77a333e6 Merge pull request #35 from osmosis-labs/boss/osmosis-testing
c1889776 Merge branch 'main' into boss/osmosis-testing
fcca8a3d add macros for impl execute / query
911807ea update rerun-if-changed path
efe83e8e bring back mutex
9d9b0b07 support build on different arch
9bb980e7 rename go to libosmosistesting
4bfba48c remove app error
ef37c5e9 remove fee setting from osmosis test app
c69c23f5 add way to customize fee
fc810c9b update exports
57064a5d Remove AsModule for canonical M::new constructor
5d23065c Make simulate_tx public
851547d5 Rename App to OsmosisTestApp
5d3331de add locks for simulate & execute
626b951b implement more error coverage
6213bb32 add requires to chain setup
87ad012f clean up go interface
9aab0353 implement app error
e92dd688 update cosmos-sdk version
5ab365a4 point osmosis to v12.0.0-rc0
57fe26ff move being/end block for init_account to rust side
ac9d0cf4 move code into their respective module
75392359 improve error type for execute
530f8f68 make add mod extended by default
e557162a update osmosis version to 12
4da9313c bump version to 0.1.6
12d81c6e Merge pull request #38 from osmosis-labs/boss/generic-querier
e1d9ed36 Merge pull request #37 from larry0x/main
dd9254eb allow native module's queier wrapper to accept generic QuerierWrapper
03e508f0 fix staking issue
8c8bb513 create module extension for runner
628d5299 expose query
6898f332 add init accounts
9ff45ed1 Osmosis queriers do not take ownership of `QuerierWrapper`
2cd95aee concurrent test fail crisis module
ee5a40c7 improve commit tx test
dae2c49e fix default denom from stake to uosmo
bb594ee5 make commit tx works
86ccd5ea make query return result type
8e1a4cd4 Allow big wasm file for testing
2d1160cb fix concurrency issue using locks
dc77281e implement app result for decoding result type
175ce061 make execute contract return result
a688de2d clean up log msg for now
c45610f5 trying to fix issue
c7c02cae change dyn to generic type
c928ae0b change impl to dyn Account
733fe5fd add trait derives
13de5eb9 add note for test_commit_tx
a38411b5 create simple pool example
724116c5 simplify concurrent map test
ebd3cdbb use cw_whitelist for testing instead
3c66fb62 rename instantiate to instantiate contract
bf8cec8d rename execute to execute contract
a9e1b042 expose contract query
fcbe9be3 enforce the interface to use cosmwasm_std's coins
06544b84 expose contract execute
f9d38a32 clean up duplicate codes
bb9c356b expose init contract
50bc4573 use sync.Map to register env to avoid concurrent map write
c3e834ac update example for testing
5a7794ad expose (wip) commit tx function
959518a6 rename testchain to app
99927879 return signing account on init_accout
aa429859 rename test_env to test_chain
9882a737 export SubmitTx
b26ca4fc make code info optional
83784267 implement store code
07a67253 Change query creator denom to created denom in example
dc209c3b create integration test environment setup api
2e8bc9bc bump version to 0.1.5
70840a85 Update README.md
647e9d48 update documentation
2c24d866 add crate list
9662a4bf Merge pull request #31 from osmosis-labs/boss/fix-mismatch-type-url
b92eb56f refactor organization
06fb0b21 fix mismatch type_url due to prost using .to_upper_camel_case() on type name
c8f86ec6 Merge pull request #28 from osmosis-labs/boss/module-specific-querier
5b8a4891 extract querier generation
e4534409 pass file descriptor down the stack
57c91377 Move all the codegen logic to codegen module
434bd31d Extract logics to their respective module
7032bbca Setup codegen struct
a7a0d48d Improve logging with loggin lib
1cf7b178 update example to use new api
548f94bf create fns that hides explicit req types
930a10f9 change *QuerierWrapper to *Querier
bf0315fd Generate querier wrapper for all modules
7673fbac Add coin conversion
bda05969 Remove cosmos-sdk-proto dep
8db46ced Add .idea to gitignore
69491376 Cleanup example code and add state.local.json to gitignore
b147064c remove unused imports from example contract
6f1a5d64 make query fn pub
97e92c80 gen query fn:
67b1cbd7 change attr naming convention
18757151 add query attrs for later gen query fn
26a0b42d bump version to 0.1.3
289e98ae remove unused imports in examples/cosmwasm
2fa2df92 Update to v11.0.0 with JSONSchema
9d1fb114 Merge pull request #16 from osmosis-labs/osmosis/cosmos-sdk
71401b4b cargo run proto-build
9a7c811b update dependencies
5da0d5ea make query response deserializable
49f43961 Merge branch 'main' of github.com:osmosis-labs/osmosis-rust
a3292168 ignore local state
d9fcb5ca upgrade example to depends on 0.1.2
cc934596 Update README.md
e7b7584b v0.1.2
f8754691 v0.1.1
f217b7b4 format with generated code with rustfmt
a9698613 add response decode to derive
330b2fe6 refactor to remove include
b52dab10 add create pool example
d69974b8 Update README.md
001f9b8f add contract example
7945a2c3 generate mod.rs
5ad87a9e v0.1.0
8fcd4fbb add pool models
ea7dd77b Add derive cosmwasm ext
8f9d0f74 prep for derive
4eea7bbb generate ToCosmosMsg
90acf46f  rename osmosis-proto to osmosis-std
725b15eb auto detect all protos
b2b00aa1 reduce module depth
4a2ec8c3 disable default-features for cosmos-sdk-proto to get rid of non-determinism
e286e9d4 generate and prettify rust type from proto
16a80013 update gitmodules
ce69efb0 Create README.md
356d0ff1 cleanup unrelated code
REVERT: 0b4a7ef mv osmosis

git-subtree-dir: integrations/osmosis
git-subtree-split: 362938335b26a10197958aa89b97bebdbdd2a642
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants