Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove speculoos from dependency #501

Merged
merged 19 commits into from
Oct 21, 2024

Conversation

Buckram123
Copy link
Collaborator

@Buckram123 Buckram123 commented Oct 16, 2024

This PR removes speculoos from dependency

  • framework
  • modules
  • interchain

There are few assert_that!'s left in modules but they are non-testable because we don't currently have wyndex-bundle

@Buckram123 Buckram123 marked this pull request as draft October 16, 2024 12:12
Copy link

cloudflare-workers-and-pages bot commented Oct 16, 2024

Deploying abstract-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: aa85ee3
Status:⚡️  Build in progress...

View logs

@Buckram123 Buckram123 marked this pull request as ready for review October 16, 2024 12:20
@Buckram123 Buckram123 mentioned this pull request Oct 16, 2024
2 tasks
Copy link
Contributor

@Kayanski Kayanski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice !
The only issue I see is that debugging a test that fails is now more difficult because assertions are not very verbose when they fail, but that's ok I guess

Base automatically changed from develop/v2 to main October 16, 2024 13:11
@Kayanski Kayanski merged commit 6aa7888 into main Oct 21, 2024
15 of 24 checks passed
@Kayanski Kayanski deleted the misha/abs-478-remove-speculoos-from-dependency branch October 21, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants