Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nicolas/abs 547 remove unsued error variants #499

Merged
merged 21 commits into from
Oct 22, 2024
Merged

Nicolas/abs 547 remove unsued error variants #499

merged 21 commits into from
Oct 22, 2024

Conversation

Kayanski
Copy link
Contributor

@Kayanski Kayanski commented Oct 16, 2024 •
edited
Loading

This PR aims at removing all unused errors variants.

Contract Checklist

  • Account
  • ANS Host
  • Ibc Client
  • Ibc Host
  • Ica Client
  • Module Factory
  • Registry

Package Checklist

  • Adapter
  • App
  • Client
  • Interface
  • sdk
  • standalone
  • std
  • standards

--> Stopping at standards, because most implementations are still not reactivated (feature flagged or commented out)

Checklist

  • CI is green.
  • Changelog updated.

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Oct 16, 2024 •
edited
Loading

Deploying abstract-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 70f519f
Status: ✅  Deploy successful!
Preview URL: https://ef238ec1.abstract-docs.pages.dev
Branch Preview URL: https://nicolas-abs-547-remove-unsue.abstract-docs.pages.dev

View logs

@codecov Codecov
Copy link

codecov bot commented Oct 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.7%. Comparing base (bf989a9) to head (2b839d9).

Additional details and impacted files

@Kayanski Kayanski changed the base branch from main to develop/v2 October 16, 2024 08:17
@Kayanski Kayanski marked this pull request as ready for review October 16, 2024 13:11
Base automatically changed from develop/v2 to main October 16, 2024 13:11
@github-actions github-actions bot removed CI documentation Improvements or additions to documentation labels Oct 16, 2024
CyberHoward
CyberHoward approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@CyberHoward CyberHoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

Buckram123
Buckram123 approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@Buckram123 Buckram123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Wonder how did you even check it? Commenting it out one by one to check if used?

framework/contracts/account/src/error.rs Show resolved Hide resolved
@Kayanski Kayanski merged commit 4818534 into main Oct 22, 2024
18 of 24 checks passed
@Kayanski Kayanski deleted the nicolas/abs-547-remove-unsued-error-variants branch October 22, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Buckram123 Buckram123 Buckram123 approved these changes

@CyberHoward CyberHoward CyberHoward approved these changes

Assignees
No one assigned
Labels
account adapter_base app_base interface native sdk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kayanski @CyberHoward @Buckram123